test: add validation test for extension pre-standalone default

This allows us to verify that the extension properly deals with
pre-v19 projects and `standalone: false`

Author: devversion

.bazelignore

@@ -5,6 +5,7 @@ integration/project/node_modules/
 integration/project/libs/post/node_modules
 integration/project/dist/
 integration/workspace/node_modules/
+integration/pre_standalone_project/node_modules/
 
 override_rename_ts_plugin/node_modules
 server/node_modules

.circleci/config.yml

@@ -23,6 +23,9 @@ jobs:
       - node/install-packages:
           app-dir: integration/pre_apf_project
           pkg-manager: yarn
+      - node/install-packages:
+          app-dir: integration/pre_standalone_project
+          pkg-manager: yarn
       - node/install-packages:
           app-dir: integration/workspace
           pkg-manager: yarn

WORKSPACE

@@ -153,3 +153,18 @@ npm_translate_lock(
 load("@npm_integration_project//:repositories.bzl", npm_integration_project_repositories = "npm_repositories")
 
 npm_integration_project_repositories()
+
+npm_translate_lock(
+    name = "npm_integration_pre_standalone_project",
+    data = [
+        "//integration/pre_standalone_project:package.json",
+        "//integration/pre_standalone_project:pnpm-workspace.yaml",
+    ],
+    npmrc = "//:.npmrc",
+    pnpm_lock = "//integration/pre_standalone_project:pnpm-lock.yaml",
+    verify_node_modules_ignored = "//:.bazelignore",
+)
+
+load("@npm_integration_pre_standalone_project//:repositories.bzl", npm_integration_pre_standalone_project_repositories = "npm_repositories")
+
+npm_integration_pre_standalone_project_repositories()

integration/lsp/BUILD.bazel

@@ -6,6 +6,9 @@ jasmine_test(
     data = [
         "//integration",
         "//integration/project",
+        "//integration/pre_standalone_project",
+        "//integration/pre_standalone_project:node_modules/@angular/core",
+        "//integration/pre_standalone_project:node_modules/@angular/common",
         "//server:index",
     ],
     args = ["*_spec.js"],

integration/lsp/ivy_spec.ts

@@ -7,16 +7,17 @@
  */
 
 import * as fs from 'fs';
+import {join} from 'path';
 import {promisify} from 'util';
 import {MessageConnection} from 'vscode-jsonrpc';
 import * as lsp from 'vscode-languageserver-protocol';
 import {URI} from 'vscode-uri';
 
 import {ProjectLanguageService, ProjectLanguageServiceParams, SuggestStrictMode, SuggestStrictModeParams} from '../../common/notifications';
 import {GetComponentsWithTemplateFile, GetTcbRequest, GetTemplateLocationForComponent, IsInAngularProject} from '../../common/requests';
-import {APP_COMPONENT, APP_COMPONENT_MODULE_URI, APP_COMPONENT_URI, BAR_COMPONENT, BAR_COMPONENT_URI, FOO_COMPONENT, FOO_COMPONENT_URI, FOO_TEMPLATE, FOO_TEMPLATE_URI, IS_BAZEL, PROJECT_PATH, TSCONFIG} from '../test_constants';
+import {APP_COMPONENT, APP_COMPONENT_MODULE_URI, APP_COMPONENT_URI, BAR_COMPONENT, BAR_COMPONENT_URI, FOO_COMPONENT, FOO_COMPONENT_URI, FOO_TEMPLATE, FOO_TEMPLATE_URI, IS_BAZEL, PRE_STANDALONE_PROJECT_PATH, PROJECT_PATH, TSCONFIG} from '../test_constants';
 
-import {convertPathToFileUrl, createConnection, createTracer, initializeServer, openTextDocument} from './test_utils';
+import {convertPathToFileUrl, createConnection, createTracer, initializeServer, openTextDocument, ServerOptions} from './test_utils';
 
 const setTimeoutP = promisify(setTimeout);
 
@@ -26,20 +27,25 @@ describe('Angular Ivy language server', () => {
   let client: MessageConnection;
 
   beforeEach(async () => {
+    await initServer({});
+  });
+
+  afterEach(() => {
+    client.dispose();
+  });
+
+  async function initServer(options: Partial<ServerOptions>) {
     client = createConnection({
       ivy: true,
+      ...options,
     });
     // If debugging, set to
     // - lsp.Trace.Messages to inspect request/response/notification, or
     // - lsp.Trace.Verbose to inspect payload
     client.trace(lsp.Trace.Off, createTracer());
     client.listen();
     await initializeServer(client);
-  });
-
-  afterEach(() => {
-    client.dispose();
-  });
+  }
 
   it('should handle hover on inline template', async () => {
     openTextDocument(client, APP_COMPONENT);
@@ -547,6 +553,15 @@ export class AppComponent {
     expect(response).toBeNull();
   });
 
+  it('should handle apps where standalone is not enabled by default (pre v19)', async () => {
+    await initServer({angularCoreVersion: '18.0.0'})
+    const moduleFile = join(PRE_STANDALONE_PROJECT_PATH, 'app/app.module.ts');
+
+    openTextDocument(client, moduleFile);
+    const diagnostics = await getDiagnosticsForFile(client, moduleFile);
+    expect(diagnostics.length).toBe(0);
+  });
+
   it('should provide a "go to component" codelens', async () => {
     openTextDocument(client, FOO_TEMPLATE);
     const codeLensResponse = await client.sendRequest(lsp.CodeLensRequest.type, {

integration/lsp/test_utils.ts

@@ -18,6 +18,7 @@ export interface ServerOptions {
   ivy: boolean;
   includeAutomaticOptionalChainCompletions?: boolean;
   includeCompletionsWithSnippetText?: boolean;
+  angularCoreVersion?: string;
 }
 
 export function createConnection(serverOptions: ServerOptions): MessageConnection {
@@ -37,6 +38,9 @@ export function createConnection(serverOptions: ServerOptions): MessageConnectio
   if (serverOptions.includeCompletionsWithSnippetText) {
     argv.push('--includeCompletionsWithSnippetText');
   }
+  if (serverOptions.angularCoreVersion) {
+    argv.push('--angularCoreVersion', serverOptions.angularCoreVersion);
+  }
   const server = fork(SERVER_PATH, argv, {
     cwd: PROJECT_PATH,
     // uncomment to debug server process

integration/pre_standalone_project/BUILD.bazel

@@ -0,0 +1,12 @@
+load("@npm_integration_pre_standalone_project//:defs.bzl", "npm_link_all_packages")
+load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_to_bin")
+
+npm_link_all_packages(name = "node_modules")
+
+copy_to_bin(
+    name = "pre_standalone_project",
+    srcs = glob(["**"]),
+    visibility = [
+        "//integration/lsp:__pkg__",
+    ],
+)

integration/pre_standalone_project/app/app.component.ts

@@ -0,0 +1,11 @@
+import {Component, EventEmitter, Input, Output} from '@angular/core';
+
+@Component({
+  selector: 'my-app',
+  template: `<h1>Hello {{name}}</h1>`,
+})
+export class AppComponent {
+  name = 'Angular';
+  @Input() appInput = '';
+  @Output() appOutput = new EventEmitter<string>();
+}

integration/pre_standalone_project/app/app.module.ts

@@ -0,0 +1,18 @@
+import {CommonModule} from '@angular/common';
+import {NgModule} from '@angular/core';
+
+import {AppComponent} from './app.component';
+import {FooComponent} from './foo.component';
+
+@NgModule({
+  imports: [
+    CommonModule,
+  ],
+  declarations: [
+    AppComponent,
+    FooComponent,
+  ],
+  bootstrap: [AppComponent]
+})
+export class AppModule {
+}

integration/pre_standalone_project/app/foo.component.html

@@ -0,0 +1,4 @@
+{{title | uppercase}}
+<span class="subtitle">
+    subtitle
+</span>

integration/pre_standalone_project/app/foo.component.ts

@@ -0,0 +1,8 @@
+import {Component} from '@angular/core';
+
+@Component({
+  templateUrl: 'foo.component.html',
+})
+export class FooComponent {
+  title = 'Foo Component';
+}

integration/pre_standalone_project/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "angular-ls-integration-test-project",
+  "private": true,
+  "dependencies": {
+    "@angular/common": "18.2.10",
+    "@angular/core": "18.2.10"
+  }
+}

integration/pre_standalone_project/pnpm-lock.yaml

@@ -0,0 +1,2 @@
+packages:
+  - .

integration/pre_standalone_project/pnpm-workspace.yaml

@@ -0,0 +1,15 @@
+{
+  "compilerOptions": {
+    "moduleResolution": "node",
+    "experimentalDecorators": true,
+    "target": "es2015",
+    "strict": true,
+    "typeRoots": [
+      "node_modules/@types"
+    ]
+  },
+  "angularCompilerOptions": {
+    "strictTemplates": true,
+    "strictInjectionParameters": true
+  }
+}

integration/pre_standalone_project/tsconfig.json

@@ -7,6 +7,9 @@ export const PACKAGE_ROOT = IS_BAZEL ? resolve(__dirname, '..') : resolve(__dirn
 export const SERVER_PATH = IS_BAZEL ? join(PACKAGE_ROOT, 'server', 'index.js') :
                                       join(PACKAGE_ROOT, 'dist', 'npm', 'server', 'index.js');
 export const PROJECT_PATH = join(PACKAGE_ROOT, 'integration', 'project');
+export const PRE_STANDALONE_PROJECT_PATH =
+    join(PACKAGE_ROOT, 'integration', 'pre_standalone_project');
+
 export const APP_COMPONENT = join(PROJECT_PATH, 'app', 'app.component.ts');
 export const APP_COMPONENT_URI = convertPathToFileUrl(APP_COMPONENT);
 export const BAR_COMPONENT = join(PROJECT_PATH, 'app', 'bar.component.ts');
@@ -17,4 +20,4 @@ export const FOO_TEMPLATE = join(PROJECT_PATH, 'app', 'foo.component.html');
 export const FOO_TEMPLATE_URI = convertPathToFileUrl(FOO_TEMPLATE);
 export const FOO_COMPONENT = join(PROJECT_PATH, 'app', 'foo.component.ts');
 export const FOO_COMPONENT_URI = convertPathToFileUrl(FOO_COMPONENT);
-export const TSCONFIG = join(PROJECT_PATH, 'tsconfig.json');
+export const TSCONFIG = join(PROJECT_PATH, 'tsconfig.json');