Skip to content

Commit 2486fda

Browse files
committed
fix(ls): move to the latest langauge service package format
1 parent e637937 commit 2486fda

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

client/src/extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export function activate(context: ExtensionContext) {
99
// The server is implemented in node
1010
let serverModule = context.asAbsolutePath(path.join('server', 'server.js'));
1111
// The debug options for the server
12-
let debugOptions = { execArgv: ["--nolazy", "--debug-brk=6004"] };
12+
let debugOptions = { execArgv: ["--nolazy", "--debug=6004"] };
1313

1414
// If the extension is launched in debug mode then the debug server options are used
1515
// Otherwise the run options are used

server/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@
1212
"watch": "installServerIntoExtension ../client ./package.json ./tsconfig.json && tsc --watch -p ."
1313
},
1414
"dependencies": {
15-
"@angular/language-service": "file:///Users/chuckj/src/angular/dist/packages-dist/language-service",
16-
"@angular/tsc-wrapped": "file:///Users/chuckj/src/angular/dist/tools/@angular/tsc-wrapped",
1715
"reflect-metadata": "^0.1.8",
18-
"rxjs": "^5.0.0-beta.12",
1916
"typescript": "2.0.2",
2017
"vscode-languageserver": "^2.4.0-next.9",
21-
"zone.js": "^0.6.25"
18+
"@angular/language-service": "file:///Users/chuckj/src/angular/dist/packages-dist/language-service"
2219
},
2320
"devDependencies": {
21+
"rxjs": "^5.0.0-beta.12",
22+
"zone.js": "^0.6.25",
23+
"@angular/tsc-wrapped": "file:///Users/chuckj/src/angular/dist/tools/@angular/tsc-wrapped",
2424
"@angular/compiler": "file:///Users/chuckj/src/angular/dist/packages-dist/compiler",
2525
"@angular/compiler-cli": "file:///Users/chuckj/src/angular/dist/packages-dist/compiler-cli",
2626
"@angular/core": "file:///Users/chuckj/src/angular/dist/packages-dist/core",

server/src/editorServices.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2015,20 +2015,25 @@ export class CompilerService {
20152015
resolveLanguageServiceModule(): typeof ng {
20162016
const host = path.resolve(this.host.getCurrentDirectory(), 'main.ts');
20172017
const modules = this.host.resolveModuleNames(['@angular/language-service'], host);
2018+
let result = ng;
20182019
if (modules && modules[0]) {
20192020
const resolvedModule = modules[0];
20202021
const moduleName = path.dirname(resolvedModule.resolvedFileName);
20212022
if (fs.existsSync(moduleName)) {
20222023
try {
2023-
const result: typeof ng = require(moduleName);
2024-
if (result) return result;
2024+
result = require(moduleName) || result;
20252025
} catch(e) {
20262026
this.log(`Error loading module "${moduleName}"; using local language service instead`);
20272027
this.log(e.stack);
20282028
}
20292029
}
20302030
}
2031-
return ng;
2031+
if (typeof result === 'function') {
2032+
// The language service bundle exposes a function to allow hooking module dependencies
2033+
// such as TypeScript. However, using require() here is sufficient for us.
2034+
result = result();
2035+
}
2036+
return result;
20322037
}
20332038

20342039
private log(message: string) {

0 commit comments

Comments
 (0)