Skip to content

Commit 90560ac

Browse files
committed
refactor: remove docker sys_admin capability
1 parent ef6568f commit 90560ac

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

bazel/browsers/chromium/chromium.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"browserName": "chrome",
55
"goog:chromeOptions": {
66
"binary": "%FILE:CHROMIUM%",
7-
"args": ["--headless", "--use-gl=swiftshader-webgl"]
7+
"args": ["--headless", "--use-gl=swiftshader-webgl", "--no-sandbox"]
88
},
99
"google:wslConfig": {
1010
"binary": "%FILE:CHROMEDRIVER%",

bazel/remote-execution/BUILD.bazel

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ platform(
1616
# it needs to be updated. e.g. for a more recent Bash version, or new system settings that are
1717
# required for launching browsers.
1818
"container-image": "docker://us-west2-docker.pkg.dev/internal-200822/remote-execution-images/angular-devinfra-rbe-image@sha256:3389d808edbcdf8999338fd617dda68cdbaa259b431f19e41e58941cdac900a3",
19-
# The `SYS_ADMIN` capability is added so that browsers can be launched with sandbox mode enabled. Related
20-
# # information: https://developers.google.com/web/tools/puppeteer/troubleshooting#running_puppeteer_in_docker
21-
"dockerAddCapabilities": "SYS_ADMIN",
2219
# By default in Google Cloud Remote build execution, network access is disabled. We explicitly set the
2320
# property in the platform again in case the default ever changes. Network access is not desirable in
2421
# Bazel builds as it is potential source of flaky tests and therefore also breaks hermeticity.

0 commit comments

Comments
 (0)