Skip to content

Commit 8ca74b8

Browse files
committed
fix(ng-dev): add additional context for why retries occur during github API requests in merge process (#2753)
PR Close #2753
1 parent c4207bf commit 8ca74b8

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

ng-dev/release/publish/actions.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,10 @@ export abstract class ReleaseAction {
735735
* release commit and is the direct child of the previous sha provided.
736736
*
737737
* The method will make one recursive attempt to check again before throwing an error if
738-
* any error occurs during this validation.
738+
* any error occurs during this validation. This exists as an attempt to handle transient
739+
* timeouts from Github along with cases, where the Github API response does not keep up
740+
* with the timing from when we perform a merge to when we verify that the merged commit is
741+
* present in the upstream branch.
739742
*/
740743
private async _getAndValidateLatestCommitForPublishing(
741744
branch: string,

0 commit comments

Comments
 (0)