build: remove windows testing and CI setup

NOTE: This does not mean we are no longer supporting contributing to
Angular on a Windows machine. Instead, we are working towards having a
more stable and guaranteed developer experience on Windows! We will
still ensure and verify that the Angular CLI (`ng`) works on Windows!

---

Many contributors and team members are using Linux or MacOS for
development of Angular. Our tooling regularly faces challenges with
infrastructure needing extra work and tricks just to function to some
extent on Windows. E.g. shell scripts or Bazel actions that need extra
layers for batch files that spawn a Bash shell etc, or inconsistent
escaping across shells. This is putting extra stress on our
infrastructure team, results in in unnecessary complexity and slows down
overall development that way.

There is a simple and well-proven solution for supporting Windows
development. Using WSL2, developes have access to a Bash shell that is
equivalent to Linux; which we use on a day to day basis and can
guarantee that development works smoothly! This means, we'd be able to
offer far better stability and guarantees to our Windows contributors.

Historically, we also haven't seen a lot of Angular contributors use
Windows; and if they did; they already used WSL for development. At this
point we don't have any non-WSL contributors anymore (in the team or
known), so we don't know anything about how well development works via
e.g. Git Bash on Windows.

Testing on CI via Windows WSL is not necessary as the WSL shell is
expected to be the same as the Linux bash environment. We'll be able to
revisit this if we have new learnings. There are ways to execute builds
etc. via WSL on CI.

Author: devversion

.github/workflows/pr.yml

@@ -56,20 +56,6 @@ jobs:
       - run: yarn install --immutable
       - run: yarn bazel test -- //...
 
-  test-win:
-    timeout-minutes: 30
-    runs-on: windows-latest
-    steps:
-      # Because the checkout and setup node action is contained in the dev-infra repo, we must
-      # checkout the repo to be able to run the action we have created.  Other repos will skip
-      # this step.
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: ./github-actions/npm/checkout-and-setup-node
-      - uses: ./github-actions/bazel/setup
-      - uses: ./github-actions/bazel/configure-remote
-      - run: yarn install --immutable
-      - run: yarn bazel test --test_tag_filters=windows --build_tests_only -- ... -bazel/remote-execution/...
-
   test-macos:
     timeout-minutes: 30
     runs-on: macos-latest

WORKSPACE

@@ -136,7 +136,6 @@ register_toolchains(
     "//bazel/git-toolchain:git_linux_toolchain",
     "//bazel/git-toolchain:git_macos_x86_toolchain",
     "//bazel/git-toolchain:git_macos_arm64_toolchain",
-    "//bazel/git-toolchain:git_windows_toolchain",
 )
 
 http_file(

bazel/api-golden/test/BUILD.bazel

@@ -21,8 +21,6 @@ api_golden_test(
     ],
     entry_point = "./fixtures/test_fixture.d.ts",
     golden = "dev-infra/bazel/api-golden/test/goldens/explicit_file",
-    # API extractor type resolution is prone to non-sandbox errors, so we test Windows.
-    tags = ["windows"],
     types = ["@npm//@types/node"],
 )
 
@@ -34,8 +32,6 @@ api_golden_test_npm_package(
     ],
     golden_dir = "dev-infra/bazel/api-golden/test/goldens/test_package",
     npm_package = "dev-infra/bazel/api-golden/test/fixtures/test_package",
-    # API extractor type resolution is prone to non-sandbox errors, so we test Windows.
-    tags = ["windows"],
     # API extractor needs to be able to resolve `@babel/core` due to an aliased namespace
     # we expose as part of the `nested.d.ts` fake entry-point.
     types = ["@npm//@types/babel__core"],
@@ -49,6 +45,4 @@ api_golden_test_npm_package(
     ],
     golden_dir = "dev-infra/bazel/api-golden/test/goldens/pkg_no_exports_field",
     npm_package = "dev-infra/bazel/api-golden/test/fixtures/pkg_no_exports_field",
-    # API extractor type resolution is prone to non-sandbox errors, so we test Windows.
-    tags = ["windows"],
 )

bazel/browsers/test/BUILD.bazel

@@ -11,7 +11,6 @@ karma_web_test_suite(
     tags = [
         "linux",
         "macos",
-        "windows",
     ],
     deps = [
         ":test_bundle",

bazel/git-toolchain/BUILD.bazel

@@ -1,5 +1,5 @@
-load(":toolchain.bzl", "git_toolchain")
 load(":alias.bzl", "git_toolchain_alias")
+load(":toolchain.bzl", "git_toolchain")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -74,17 +74,3 @@ toolchain(
     toolchain = ":git_macos_arm64",
     toolchain_type = ":toolchain_type",
 )
-
-toolchain(
-    name = "git_windows_toolchain",
-    exec_compatible_with = [
-        "@platforms//os:windows",
-        "@platforms//cpu:x86_64",
-    ],
-    target_compatible_with = [
-        "@platforms//os:windows",
-        "@platforms//cpu:x86_64",
-    ],
-    toolchain = ":git_windows",
-    toolchain_type = ":toolchain_type",
-)

bazel/integration/tests/package_mappings/BUILD.bazel

@@ -13,11 +13,6 @@ integration_test(
     npm_packages = {
         "//bazel/integration/tests/package_mappings/fake_pkg_srcs:archive": "fake_pkg",
     },
-    tags = [
-        # We want to run a basic integration test on Windows to ensure the integration
-        # test rule works properly for Windows contributors.
-        "windows",
-    ],
     tool_mappings = {
         "//:yarn_classic_vendored": "yarn",
         "@nodejs_toolchains//:resolved_toolchain": "node",