Skip to content

Commit 877de56

Browse files
crisbetommalerba
authored andcommitted
build: rename @deletion-target to @Breaking-Change (#12421)
As discussed, renames the `@deletion-target` tag to `@breaking-change` to make the intentions of the tag clearer. Also adds an extra check to the tslint rule to catch any leftover `@deletion-target` tags.
1 parent 4e358c3 commit 877de56

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+128
-115
lines changed

src/cdk/a11y/aria-describer/aria-describer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,12 +225,12 @@ export class AriaDescriber implements OnDestroy {
225225
}
226226

227227

228-
/** @docs-private @deprecated @deletion-target 7.0.0 */
228+
/** @docs-private @deprecated @breaking-change 7.0.0 */
229229
export function ARIA_DESCRIBER_PROVIDER_FACTORY(parentDispatcher: AriaDescriber, _document: any) {
230230
return parentDispatcher || new AriaDescriber(_document);
231231
}
232232

233-
/** @docs-private @deprecated @deletion-target 7.0.0 */
233+
/** @docs-private @deprecated @breaking-change 7.0.0 */
234234
export const ARIA_DESCRIBER_PROVIDER = {
235235
// If there is already an AriaDescriber available, use that. Otherwise, provide a new one.
236236
provide: AriaDescriber,

src/cdk/a11y/focus-monitor/focus-monitor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,13 +402,13 @@ export class CdkMonitorFocus implements OnDestroy {
402402
}
403403
}
404404

405-
/** @docs-private @deprecated @deletion-target 7.0.0 */
405+
/** @docs-private @deprecated @breaking-change 7.0.0 */
406406
export function FOCUS_MONITOR_PROVIDER_FACTORY(
407407
parentDispatcher: FocusMonitor, ngZone: NgZone, platform: Platform) {
408408
return parentDispatcher || new FocusMonitor(ngZone, platform);
409409
}
410410

411-
/** @docs-private @deprecated @deletion-target 7.0.0 */
411+
/** @docs-private @deprecated @breaking-change 7.0.0 */
412412
export const FOCUS_MONITOR_PROVIDER = {
413413
// If there is already a FocusMonitor available, use that. Otherwise, provide a new one.
414414
provide: FocusMonitor,

src/cdk/a11y/focus-trap/focus-trap.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ export class FocusTrap {
152152
`[cdk-focus-${bound}]`) as NodeListOf<HTMLElement>;
153153

154154
for (let i = 0; i < markers.length; i++) {
155-
// @deletion-target 7.0.0
155+
// @breaking-change 7.0.0
156156
if (markers[i].hasAttribute(`cdk-focus-${bound}`)) {
157157
console.warn(`Found use of deprecated attribute 'cdk-focus-${bound}', ` +
158158
`use 'cdkFocusRegion${bound}' instead. The deprecated ` +
@@ -181,7 +181,7 @@ export class FocusTrap {
181181
`[cdkFocusInitial]`) as HTMLElement;
182182

183183
if (redirectToElement) {
184-
// @deletion-target 7.0.0
184+
// @breaking-change 7.0.0
185185
if (redirectToElement.hasAttribute(`cdk-focus-initial`)) {
186186
console.warn(`Found use of deprecated attribute 'cdk-focus-initial', ` +
187187
`use 'cdkFocusInitial' instead. The deprecated attribute ` +

src/cdk/a11y/key-manager/list-key-manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ export class ListKeyManager<T extends ListKeyManagerOption> {
305305
* Allows setting of the activeItemIndex without any other effects.
306306
* @param index The new activeItemIndex.
307307
* @deprecated Use `updateActiveItem` instead.
308-
* @deletion-target 7.0.0
308+
* @breaking-change 7.0.0
309309
*/
310310
updateActiveItemIndex(index: number): void {
311311
this.updateActiveItem(index);

src/cdk/a11y/live-announcer/live-announcer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,14 +132,14 @@ export class CdkAriaLive implements OnDestroy {
132132
}
133133

134134

135-
/** @docs-private @deprecated @deletion-target 7.0.0 */
135+
/** @docs-private @deprecated @breaking-change 7.0.0 */
136136
export function LIVE_ANNOUNCER_PROVIDER_FACTORY(
137137
parentDispatcher: LiveAnnouncer, liveElement: any, _document: any) {
138138
return parentDispatcher || new LiveAnnouncer(liveElement, _document);
139139
}
140140

141141

142-
/** @docs-private @deprecated @deletion-target 7.0.0 */
142+
/** @docs-private @deprecated @breaking-change 7.0.0 */
143143
export const LIVE_ANNOUNCER_PROVIDER: Provider = {
144144
// If there is already a LiveAnnouncer available, use that. Otherwise, provide a new one.
145145
provide: LiveAnnouncer,

src/cdk/overlay/keyboard/overlay-keyboard-dispatcher.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,13 @@ export class OverlayKeyboardDispatcher implements OnDestroy {
9696
}
9797

9898

99-
/** @docs-private @deprecated @deletion-target 7.0.0 */
99+
/** @docs-private @deprecated @breaking-change 7.0.0 */
100100
export function OVERLAY_KEYBOARD_DISPATCHER_PROVIDER_FACTORY(
101101
dispatcher: OverlayKeyboardDispatcher, _document: any) {
102102
return dispatcher || new OverlayKeyboardDispatcher(_document);
103103
}
104104

105-
/** @docs-private @deprecated @deletion-target 7.0.0 */
105+
/** @docs-private @deprecated @breaking-change 7.0.0 */
106106
export const OVERLAY_KEYBOARD_DISPATCHER_PROVIDER = {
107107
// If there is already an OverlayKeyboardDispatcher available, use that.
108108
// Otherwise, provide a new one.

src/cdk/overlay/overlay-container.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,13 @@ export class OverlayContainer implements OnDestroy {
5555
}
5656

5757

58-
/** @docs-private @deprecated @deletion-target 7.0.0 */
58+
/** @docs-private @deprecated @breaking-change 7.0.0 */
5959
export function OVERLAY_CONTAINER_PROVIDER_FACTORY(parentContainer: OverlayContainer,
6060
_document: any) {
6161
return parentContainer || new OverlayContainer(_document);
6262
}
6363

64-
/** @docs-private @deprecated @deletion-target 7.0.0 */
64+
/** @docs-private @deprecated @breaking-change 7.0.0 */
6565
export const OVERLAY_CONTAINER_PROVIDER = {
6666
// If there is already an OverlayContainer available, use that. Otherwise, provide a new one.
6767
provide: OverlayContainer,

src/cdk/overlay/overlay-directives.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const defaultPositionList: ConnectedPosition[] = [
7373
export const CDK_CONNECTED_OVERLAY_SCROLL_STRATEGY =
7474
new InjectionToken<() => ScrollStrategy>('cdk-connected-overlay-scroll-strategy');
7575

76-
/** @docs-private @deprecated @deletion-target 7.0.0 */
76+
/** @docs-private @deprecated @breaking-change 7.0.0 */
7777
export function CDK_CONNECTED_OVERLAY_SCROLL_STRATEGY_FACTORY(overlay: Overlay):
7878
() => ScrollStrategy {
7979
return (config?: RepositionScrollStrategyConfig) => overlay.scrollStrategies.reposition(config);

src/cdk/overlay/overlay-module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export class OverlayModule {}
3535

3636
/**
3737
* @deprecated Use `OverlayModule` instead.
38-
* @deletion-target 7.0.0
38+
* @breaking-change 7.0.0
3939
*/
4040
export const OVERLAY_PROVIDERS: Provider[] = [
4141
Overlay,

src/cdk/overlay/position/connected-position-strategy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import {OverlayReference} from '../overlay-reference';
2828
* a basic dropdown is connecting the bottom-left corner of the origin to the top-left corner
2929
* of the overlay.
3030
* @deprecated Use `FlexibleConnectedPositionStrategy` instead.
31-
* @deletion-target 7.0.0
31+
* @breaking-change 7.0.0
3232
*/
3333
export class ConnectedPositionStrategy implements PositionStrategy {
3434
/**
@@ -61,7 +61,7 @@ export class ConnectedPositionStrategy implements PositionStrategy {
6161
connectedTo: ElementRef,
6262
viewportRuler: ViewportRuler,
6363
document: Document,
64-
// @deletion-target 7.0.0 `platform` parameter to be made required.
64+
// @breaking-change 7.0.0 `platform` parameter to be made required.
6565
platform?: Platform) {
6666

6767
// Since the `ConnectedPositionStrategy` is deprecated and we don't want to maintain

0 commit comments

Comments
 (0)