build: remove deprecated node-github api (#12420)

Switches to the newer version of `node-github` that has been renamed to `@octokit/rest`.

Author: devversion

package-lock.json

@@ -53,6 +53,7 @@
     "@angular/upgrade": "6.0.0",
     "@bazel/ibazel": "0.3.1",
     "@google-cloud/storage": "^1.1.1",
+    "@octokit/rest": "^15.9.4",
     "@schematics/angular": "^0.7.1",
     "@types/chalk": "^0.4.31",
     "@types/fs-extra": "^4.0.3",
@@ -75,7 +76,6 @@
     "firebase-tools": "^3.11.0",
     "fs-extra": "^3.0.1",
     "git-semver-tags": "^2.0.0",
-    "github": "^12.0.3",
     "glob": "^7.1.2",
     "google-closure-compiler": "20170409.0.0",
     "gulp": "^3.9.1",

package.json

@@ -2,7 +2,7 @@
 
 const path = require('path');
 const fs = require('fs');
-const GitHubApi = require('github');
+const GitHubApi = require('@octokit/rest');
 const github = new GitHubApi();
 
 
@@ -30,6 +30,14 @@ const intervalMinutes = 10;
 /** Instead of querying github for PR numbers, manually provide the PR numbers to be presubmit */
 const explicitPullRequests = [];
 
+/** Options that will be passed to the octokit Github API when querying Github for PR numbers. */
+const githubSearchOptions = {
+  // Use the maximum of allowed items per Github API query. 100 pull requests should be
+  // enough to continuously run presubmits through night.
+  per_page: 100,
+  q: 'repo:angular/material2 is:open type:pr label:"pr: merge ready" -label:"pr: merge safe"',
+};
+
 /** END OF CONFIGURATION. */
 
 
@@ -41,17 +49,9 @@ if (explicitPullRequests.length) {
   writeScheduleScript(explicitPullRequests.map(n => ({number: n})));
 } else {
   // Fetch PRs that are merge-ready but not merge-safe
-  github.search.issues({
-    per_page: 100,
-    q: 'repo:angular/material2 is:open type:pr label:"pr: merge ready" -label:"pr: merge safe"',
-  }, (error, response) => {
-    if (response) {
-      writeScheduleScript(response.data.items);
-    } else {
-      console.error('Fetching merge-ready PRs failed.');
-      console.error(error);
-    }
-  });
+  github.search.issues(githubSearchOptions)
+    .then(response => writeScheduleScript(response.data.items))
+    .catch(error => console.error('Fetching merge-ready PRs failed.', error));
 }