chore: add missing lifecycles interfaces to declarations (#10768)

Author: rafaelss95

package-lock.json

@@ -68,6 +68,7 @@
     "axe-core": "^2.3.1",
     "axe-webdriverjs": "^1.1.1",
     "chalk": "^1.1.3",
+    "codelyzer": "^4.3.0",
     "dgeni": "^0.4.9",
     "dgeni-packages": "^0.26.0",
     "firebase": "^4.0.0",

package.json

@@ -6,30 +6,31 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+import {animate, AnimationEvent, state, style, transition, trigger} from '@angular/animations';
+import {FocusTrapFactory} from '@angular/cdk/a11y';
 import {
-  ElementRef,
-  HostBinding,
-  ViewChild,
-  ComponentRef,
-  EmbeddedViewRef,
+  BasePortalOutlet,
+  ComponentPortal,
+  PortalHostDirective,
+  TemplatePortal
+} from '@angular/cdk/portal';
+import {DOCUMENT} from '@angular/common';
+import {
+  ChangeDetectionStrategy,
   ChangeDetectorRef,
   Component,
-  Optional,
+  ComponentRef,
+  ElementRef,
+  EmbeddedViewRef,
+  HostBinding,
   Inject,
+  OnDestroy,
+  Optional,
+  ViewChild,
   ViewEncapsulation,
-  ChangeDetectionStrategy,
 } from '@angular/core';
-import {DOCUMENT} from '@angular/common';
-import {trigger, state, style, transition, animate, AnimationEvent} from '@angular/animations';
-import {
-  BasePortalOutlet,
-  PortalHostDirective,
-  ComponentPortal,
-  TemplatePortal
-} from '@angular/cdk/portal';
-import {FocusTrapFactory} from '@angular/cdk/a11y';
-import {DialogConfig} from './dialog-config';
 import {Subject} from 'rxjs';
+import {DialogConfig} from './dialog-config';
 
 
 export function throwDialogContentAlreadyAttachedError() {
@@ -63,7 +64,7 @@ export function throwDialogContentAlreadyAttachedError() {
     '(@dialog.done)': '_onAnimationDone($event)',
   },
 })
-export class CdkDialogContainer extends BasePortalOutlet {
+export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
   /** State of the dialog animation. */
   _state: 'void' | 'enter' | 'exit' = 'enter';
 

src/cdk-experimental/dialog/dialog-container.ts

@@ -11,6 +11,7 @@ import {
   Inject,
   Injectable,
   InjectionToken,
+  OnDestroy,
   Optional,
   SkipSelf,
 } from '@angular/core';
@@ -54,7 +55,7 @@ let messagesContainer: HTMLElement | null = null;
  * @docs-private
  */
 @Injectable({providedIn: 'root'})
-export class AriaDescriber {
+export class AriaDescriber implements OnDestroy {
   private _document: Document;
 
   constructor(@Inject(DOCUMENT) _document: any) {

src/cdk/a11y/aria-describer/aria-describer.ts

@@ -7,19 +7,19 @@
  */
 
 import {
-  NgModule,
+  ComponentFactoryResolver,
   ComponentRef,
   Directive,
   EmbeddedViewRef,
-  TemplateRef,
-  ComponentFactoryResolver,
-  ViewContainerRef,
+  EventEmitter,
+  NgModule,
   OnDestroy,
   OnInit,
-  EventEmitter,
   Output,
+  TemplateRef,
+  ViewContainerRef,
 } from '@angular/core';
-import {Portal, TemplatePortal, ComponentPortal, BasePortalOutlet} from './portal';
+import {BasePortalOutlet, ComponentPortal, Portal, TemplatePortal} from './portal';
 
 
 /**
@@ -92,7 +92,7 @@ export class CdkPortalOutlet extends BasePortalOutlet implements OnInit, OnDestr
     this._attachedPortal = portal;
   }
 
-  @Output('attached') attached: EventEmitter<CdkPortalOutletAttachedRef> =
+  @Output() attached: EventEmitter<CdkPortalOutletAttachedRef> =
       new EventEmitter<CdkPortalOutletAttachedRef>();
 
   /** Component or view reference that is attached to the portal. */

src/cdk/portal/portal-directives.ts

@@ -13,6 +13,7 @@ import {
   IterableChanges,
   IterableDiffer,
   IterableDiffers,
+  OnChanges,
   SimpleChanges,
   TemplateRef,
   ViewContainerRef,
@@ -30,7 +31,7 @@ export const CDK_ROW_TEMPLATE = `<ng-container cdkCellOutlet></ng-container>`;
  * Base class for the CdkHeaderRowDef and CdkRowDef that handles checking their columns inputs
  * for changes and notifying the table.
  */
-export abstract class BaseRowDef {
+export abstract class BaseRowDef implements OnChanges {
   /** The columns to be displayed on this row. */
   columns: Iterable<string>;
 

src/cdk/table/row.ts

@@ -1,4 +1,6 @@
+import {CollectionViewer, DataSource} from '@angular/cdk/collections';
 import {
+  AfterContentInit,
   Component,
   ContentChild,
   ContentChildren,
@@ -7,12 +9,13 @@ import {
   Type,
   ViewChild
 } from '@angular/core';
-import {ComponentFixture, TestBed, fakeAsync, flush} from '@angular/core/testing';
-import {CdkTable} from './table';
-import {CollectionViewer, DataSource} from '@angular/cdk/collections';
-import {combineLatest, BehaviorSubject, Observable, of as observableOf} from 'rxjs';
+import {ComponentFixture, fakeAsync, flush, TestBed} from '@angular/core/testing';
+import {BehaviorSubject, combineLatest, Observable, of as observableOf} from 'rxjs';
 import {map} from 'rxjs/operators';
+import {CdkColumnDef} from './cell';
 import {CdkTableModule} from './index';
+import {CdkHeaderRowDef, CdkRowDef} from './row';
+import {CdkTable} from './table';
 import {
   getTableDuplicateColumnNameError,
   getTableMissingMatchingRowDefError,
@@ -21,8 +24,6 @@ import {
   getTableUnknownColumnError,
   getTableUnknownDataSourceError
 } from './table-errors';
-import {CdkHeaderRowDef, CdkRowDef} from './row';
-import {CdkColumnDef} from './cell';
 
 describe('CdkTable', () => {
   let fixture: ComponentFixture<any>;
@@ -1502,7 +1503,7 @@ class RowContextCdkTableApp {
     </cdk-table>
   `
 })
-class WrapperCdkTableApp<T> {
+class WrapperCdkTableApp<T> implements AfterContentInit {
   @ContentChildren(CdkColumnDef) columnDefs: QueryList<CdkColumnDef>;
   @ContentChild(CdkHeaderRowDef) headerRowDef: CdkHeaderRowDef;
   @ContentChildren(CdkRowDef) rowDefs: QueryList<CdkRowDef<T>>;

src/cdk/table/table.spec.ts

@@ -6,6 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+import {CollectionViewer, DataSource} from '@angular/cdk/collections';
 import {
   AfterContentChecked,
   Attribute,
@@ -22,6 +23,7 @@ import {
   IterableChangeRecord,
   IterableDiffer,
   IterableDiffers,
+  OnDestroy,
   OnInit,
   QueryList,
   TemplateRef,
@@ -30,7 +32,9 @@ import {
   ViewContainerRef,
   ViewEncapsulation,
 } from '@angular/core';
-import {CollectionViewer, DataSource} from '@angular/cdk/collections';
+import {BehaviorSubject, Observable, of as observableOf, Subject, Subscription} from 'rxjs';
+import {takeUntil} from 'rxjs/operators';
+import {CdkColumnDef} from './cell';
 import {
   BaseRowDef,
   CdkCellOutlet,
@@ -40,9 +44,6 @@ import {
   CdkHeaderRowDef,
   CdkRowDef
 } from './row';
-import {takeUntil} from 'rxjs/operators';
-import {BehaviorSubject, Observable, of as observableOf, Subject, Subscription} from 'rxjs';
-import {CdkColumnDef} from './cell';
 import {
   getTableDuplicateColumnNameError,
   getTableMissingMatchingRowDefError,
@@ -144,7 +145,7 @@ export interface RenderRow<T> {
   encapsulation: ViewEncapsulation.None,
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class CdkTable<T> implements CollectionViewer, OnInit, AfterContentChecked {
+export class CdkTable<T> implements AfterContentChecked, CollectionViewer, OnDestroy, OnInit {
   /** Subject that emits when the component has been destroyed. */
   private _onDestroy = new Subject<void>();
 

src/cdk/table/table.ts

@@ -8,33 +8,34 @@
 import {FocusableOption} from '@angular/cdk/a11y';
 import {CollectionViewer, DataSource} from '@angular/cdk/collections';
 import {
+  AfterContentChecked,
   ChangeDetectionStrategy,
   ChangeDetectorRef,
   Component,
   ContentChildren,
   Directive,
   ElementRef,
   Input,
-  IterableDiffers,
-  IterableDiffer,
   IterableChangeRecord,
+  IterableDiffer,
+  IterableDiffers,
   OnDestroy,
   OnInit,
   QueryList,
   ViewChild,
   ViewContainerRef,
   ViewEncapsulation
 } from '@angular/core';
-import {of, BehaviorSubject, Observable, Subject, Subscription} from 'rxjs';
+import {BehaviorSubject, Observable, of as observableOf, Subject, Subscription} from 'rxjs';
 import {takeUntil} from 'rxjs/operators';
+import {TreeControl} from './control/tree-control';
 import {CdkTreeNodeDef, CdkTreeNodeOutletContext} from './node';
 import {CdkTreeNodeOutlet} from './outlet';
-import {TreeControl} from './control/tree-control';
 import {
+  getTreeControlFunctionsMissingError,
   getTreeControlMissingError,
   getTreeMissingMatchingNodeDefError,
   getTreeMultipleDefaultNodeDefsError,
-  getTreeControlFunctionsMissingError,
   getTreeNoValidDataSourceError
 } from './tree-errors';
 
@@ -130,7 +131,8 @@ export class CdkTreeNode<T>  implements FocusableOption, OnDestroy {
   encapsulation: ViewEncapsulation.None,
   changeDetection: ChangeDetectionStrategy.OnPush
 })
-export class CdkTree<T> implements CollectionViewer, OnInit, OnDestroy {
+export class CdkTree<T>
+    implements AfterContentChecked, CollectionViewer, OnDestroy, OnInit {
   /** Subject that emits when the component has been destroyed. */
   private _onDestroy = new Subject<void>();
 
@@ -257,7 +259,7 @@ export class CdkTree<T> implements CollectionViewer, OnInit, OnDestroy {
     } else if (this._dataSource instanceof Observable) {
       dataStream = this._dataSource;
     } else if (Array.isArray(this._dataSource)) {
-      dataStream = of(this._dataSource);
+      dataStream = observableOf(this._dataSource);
     }
 
     if (dataStream) {

src/cdk/tree/tree.ts

@@ -6,10 +6,10 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Component, ViewChild} from '@angular/core';
 import {DataSource} from '@angular/cdk/table';
-import {merge, Observable, BehaviorSubject} from 'rxjs';
-import {MatSort, MatPaginator} from '@angular/material';
+import {Component, OnInit, ViewChild} from '@angular/core';
+import {MatPaginator, MatSort} from '@angular/material';
+import {BehaviorSubject, merge, Observable} from 'rxjs';
 import {map} from 'rxjs/operators';
 
 
@@ -34,7 +34,7 @@ const exampleData = [
   templateUrl: 'table-a11y.html',
   styleUrls: ['table-a11y.css'],
 })
-export class TableAccessibilityDemo {
+export class TableAccessibilityDemo implements OnInit {
   @ViewChild(MatSort) sort: MatSort;
   @ViewChild(MatPaginator) pager: MatPaginator;