Skip to content

Commit 309f830

Browse files
devversionjelbourn
authored andcommitted
build: enable fullTemplateTypeCheck in aot mode (#12100)
Enables `fullTemplateTypeCheck` in the aot demo app and e2e app.
1 parent 40ff3f9 commit 309f830

File tree

7 files changed

+11
-10
lines changed

7 files changed

+11
-10
lines changed

src/demo-app/bottom-sheet/bottom-sheet-demo.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Options</h2>
3838
<mat-nav-list>
3939
<mat-list-item (click)="bottomSheetRef.dismiss()" *ngFor="let action of [1, 2, 3]">
4040
<mat-icon mat-list-icon>folder</mat-icon>
41-
<span mat-line>Action {{ link }}</span>
41+
<span mat-line>Action {{ action }}</span>
4242
<span mat-line>Description</span>
4343
</mat-list-item>
4444
</mat-nav-list>

src/demo-app/bottom-sheet/bottom-sheet-demo.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export class BottomSheetDemo {
4848
template: `
4949
<mat-nav-list>
5050
<a href="#" mat-list-item (click)="handleClick($event)" *ngFor="let action of [1, 2, 3]">
51-
<span mat-line>Action {{ link }}</span>
51+
<span mat-line>Action {{ action }}</span>
5252
<span mat-line>Description</span>
5353
</a>
5454
</mat-nav-list>

src/demo-app/dialog/dialog-demo.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,6 @@ <h2>Other options</h2>
122122
</mat-form-field>
123123

124124
<p> {{ data.message }} </p>
125-
<button type="button" (click)="dialogRef.close(lastCloseResult = howMuch.value)">Close dialog</button>
125+
<button type="button" (click)="dialogRef.close(howMuch.value)">Close dialog</button>
126126
<button (click)="dialogRef.updateSize('500px', '500px').updatePosition({ top: '25px', left: '25px' });">Change dimensions</button>`
127127
</ng-template>

src/demo-app/sidenav/sidenav-demo.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
[fixedInViewport]="fixed" [fixedTopGap]="fixedTop" [fixedBottomGap]="fixedBottom">
1010
Start Side Sidenav
1111
<br>
12-
<button mat-button (click)="start.close('mouse')">Close</button>
12+
<button mat-button (click)="start.close()">Close</button>
1313
<br>
1414
<button mat-button (click)="end.open('keyboard')">Open End Side</button>
1515
<br>
@@ -24,7 +24,7 @@
2424
[fixedInViewport]="fixed" [fixedTopGap]="fixedTop" [fixedBottomGap]="fixedBottom">
2525
End Side Sidenav
2626
<br>
27-
<button mat-button (click)="end.close('mouse')">Close</button>
27+
<button mat-button (click)="end.close()">Close</button>
2828
<div class="demo-filler-content" *ngFor="let c of fillerContent">Filler Content</div>
2929
</mat-sidenav>
3030

src/demo-app/tsconfig-aot.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
],
3434
"angularCompilerOptions": {
3535
"skipTemplateCodegen": false,
36-
// TODO: disabled for now due to @angular/forms
37-
"fullTemplateTypeCheck": false
36+
"fullTemplateTypeCheck": true
3837
}
3938
}

src/e2e-app/tsconfig-build.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
],
4343
"angularCompilerOptions": {
4444
"skipMetadataEmit": true,
45-
// TODO: disabled for now due to @angular/forms
46-
"fullTemplateTypeCheck": false
45+
"fullTemplateTypeCheck": true
4746
}
4847
}

src/material-examples/tsconfig-build.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@
3737
"flatModuleOutFile": "index.js",
3838
"flatModuleId": "@angular/material-examples",
3939
"skipTemplateCodegen": true,
40-
// TODO: disabled for now due to @angular/forms
40+
// TODO(paul): Needs to stay disabled for now because when building the examples in non-release
41+
// format the metadata of Material which is required to build the examples package, are not
42+
// including all re-exports and therefore the build will fail. This issue will be fixed with
43+
// the new compiler CLI that no longer outputs metadata.
4144
"fullTemplateTypeCheck": false
4245
}
4346
}

0 commit comments

Comments
 (0)