Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Commit db61ed8

Browse files
committed
Update select.js
If selectedItems is an empty array, if(!selectedItems) is still false. It should be if(!selectedItems.length), which evaluates to true if selectedItems is empty. With the current values, errors occur at line 266, since ctrl.parserResult.source($scope) evaluates to undefined, data does not have the filter method.
1 parent 36ee169 commit db61ed8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/select.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@
261261
if (ctrl.multiple){
262262
//Remove already selected items
263263
$scope.$watchCollection('$select.selected', function(selectedItems){
264-
if (!selectedItems) return;
264+
if (!selectedItems.length) return;
265265
var data = ctrl.parserResult.source($scope);
266266
var filteredItems = data.filter(function(i) {return selectedItems.indexOf(i) < 0;});
267267
setItemsFn(filteredItems);

0 commit comments

Comments
 (0)