Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Commit 881d424

Browse files
committed
Merge pull request #135 from angular-ui/fix-check-isempty
Show placeholder correctly when model is empty
2 parents df2e931 + ac79f4d commit 881d424

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

src/bootstrap/match.tpl.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
ng-disabled="$select.disabled"
44
ng-class="{'btn-default-focus':$select.focus}";
55
ng-click="$select.activate()">
6-
<span ng-hide="$select.selected !== undefined" class="text-muted">{{$select.placeholder}}</span>
7-
<span ng-show="$select.selected !== undefined" ng-transclude></span>
6+
<span ng-show="$select.isEmpty()" class="text-muted">{{$select.placeholder}}</span>
7+
<span ng-hide="$select.isEmpty()" ng-transclude></span>
88
<span class="caret"></span>
99
</button>

src/select.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,10 @@
110110
ctrl.resetSearchInput = undefined; // Initialized inside uiSelect directive link function
111111
ctrl.refreshDelay = undefined; // Initialized inside uiSelectChoices directive link function
112112

113+
ctrl.isEmpty = function() {
114+
return angular.isUndefined(ctrl.selected) || ctrl.selected === null;
115+
};
116+
113117
var _searchInput = $element.querySelectorAll('input.ui-select-search');
114118
if (_searchInput.length !== 1) {
115119
throw uiSelectMinErr('searchInput', "Expected 1 input.ui-select-search but got '{0}'.", _searchInput.length);

src/select2/match.tpl.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
do not work: [class^="select2-choice"]
55
-->
66
<a class="select2-choice ui-select-match"
7-
ng-class="{'select2-default': $select.selected === undefined}"
7+
ng-class="{'select2-default': $select.isEmpty()}"
88
ng-click="$select.activate()">
9-
<span ng-hide="$select.selected !== undefined" class="select2-chosen">{{$select.placeholder}}</span>
10-
<span ng-show="$select.selected !== undefined" class="select2-chosen" ng-transclude></span>
9+
<span ng-show="$select.isEmpty()" class="select2-chosen">{{$select.placeholder}}</span>
10+
<span ng-hide="$select.isEmpty()" class="select2-chosen" ng-transclude></span>
1111
<span class="select2-arrow"><b></b></span>
1212
</a>

src/selectize/match.tpl.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div ng-hide="$select.open || $select.selected === undefined" class="ui-select-match" ng-transclude></div>
1+
<div ng-hide="$select.open || $select.isEmpty()" class="ui-select-match" ng-transclude></div>

0 commit comments

Comments
 (0)