Merge pull request #1040 from hightower/bugfix/focus-on-activate

dimirc · dimirc · commit 76bf9daff6a0 · 2015-07-27T21:12:58.000-05:00
Use opacity, not visibility to hide element
diff --git a/src/uiSelectDirective.js b/src/uiSelectDirective.js
@@ -262,7 +262,7 @@ uis.directive('uiSelect',
             }
 
             // Hide the dropdown so there is no flicker until $timeout is done executing.
-            dropdown[0].style.visibility = 'hidden';
+            dropdown[0].style.opacity = 0;
 
             // Delay positioning the dropdown until all choices have been added so its height is correct.
             $timeout(function(){
@@ -277,7 +277,7 @@ uis.directive('uiSelect',
               }
 
               // Display the dropdown once it has been positioned.
-              dropdown[0].style.visibility = '';
+              dropdown[0].style.opacity = 1;
             });
           } else {
               if (dropdown === null) {

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ uis.directive('uiSelect',`
`262`	`262`	`}`
`263`	`263`
`264`	`264`	`// Hide the dropdown so there is no flicker until $timeout is done executing.`
`265`		`- dropdown[0].style.visibility = 'hidden';`
	`265`	`+ dropdown[0].style.opacity = 0;`
`266`	`266`
`267`	`267`	`// Delay positioning the dropdown until all choices have been added so its height is correct.`
`268`	`268`	`$timeout(function(){`
`@@ -277,7 +277,7 @@ uis.directive('uiSelect',`
`277`	`277`	`}`
`278`	`278`
`279`	`279`	`// Display the dropdown once it has been positioned.`
`280`		`- dropdown[0].style.visibility = '';`
	`280`	`+ dropdown[0].style.opacity = 1;`
`281`	`281`	`});`
`282`	`282`	`} else {`
`283`	`283`	`if (dropdown === null) {`