Skip to content

Commit b31274e

Browse files
devversiondevversion
committed
build: ensure TS respects package.json exports
Right now `.d.ts` could incorrectly contain references to shared chunk `.d.ts`. This is addressed by properly using the `bundler` module resolution— which instructs TS to respect `exports`.
1 parent 73c84c5 commit b31274e

File tree

4 files changed

+92
-9
lines changed

4 files changed

+92
-9
lines changed

‎goldens/cdk/testing/private/index.api.md

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
## API Report File for "@angular/cdk_testing_private"
2+
3+
> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
4+
5+
```ts
6+
7+
// @public
8+
export function clearElement(element: HTMLInputElement | HTMLTextAreaElement): void;
9+
10+
// @public
11+
export function createFakeEvent(type: string, bubbles?: boolean, cancelable?: boolean, composed?: boolean): Event;
12+
13+
// @public
14+
export function createKeyboardEvent(type: string, keyCode?: number, key?: string, modifiers?: ModifierKeys, code?: string): KeyboardEvent;
15+
16+
// @public
17+
export function createMouseEvent(type: string, clientX?: number, clientY?: number, offsetX?: number, offsetY?: number, button?: number, modifiers?: ModifierKeys): MouseEvent;
18+
19+
// @public
20+
export function createPointerEvent(type: string, clientX?: number, clientY?: number, offsetX?: number, offsetY?: number, options?: PointerEventInit): PointerEvent;
21+
22+
// @public
23+
export function createTouchEvent(type: string, pageX?: number, pageY?: number, clientX?: number, clientY?: number): UIEvent;
24+
25+
// @public
26+
export function dedent(strings: TemplateStringsArray, ...values: any[]): string;
27+
28+
// @public
29+
function dispatchEvent_2<T extends Event>(node: Node | Window, event: T): T;
30+
export { dispatchEvent_2 as dispatchEvent }
31+
32+
// @public
33+
export function dispatchFakeEvent(node: Node | Window, type: string, bubbles?: boolean): Event;
34+
35+
// @public
36+
export function dispatchKeyboardEvent(node: Node, type: string, keyCode?: number, key?: string, modifiers?: ModifierKeys, code?: string): KeyboardEvent;
37+
38+
// @public
39+
export function dispatchMouseEvent(node: Node, type: string, clientX?: number, clientY?: number, offsetX?: number, offsetY?: number, button?: number, modifiers?: ModifierKeys): MouseEvent;
40+
41+
// @public
42+
export function dispatchPointerEvent(node: Node, type: string, clientX?: number, clientY?: number, offsetX?: number, offsetY?: number, options?: PointerEventInit): PointerEvent;
43+
44+
// @public
45+
export function dispatchTouchEvent(node: Node, type: string, pageX?: number, pageY?: number, clientX?: number, clientY?: number): UIEvent;
46+
47+
// @public
48+
export function isTextInput(element: Element): element is HTMLInputElement | HTMLTextAreaElement;
49+
50+
// @public
51+
export function patchElementFocus(element: HTMLElement): void;
52+
53+
// @public
54+
export function triggerBlur(element: HTMLElement): void;
55+
56+
// @public
57+
export function triggerFocus(element: HTMLElement): void;
58+
59+
// @public
60+
export function typeInElement(element: HTMLElement, ...keys: (string | {
61+
keyCode?: number;
62+
key?: string;
63+
})[]): void;
64+
65+
// @public
66+
export function typeInElement(element: HTMLElement, modifiers: ModifierKeys, ...keys: (string | {
67+
keyCode?: number;
68+
key?: string;
69+
})[]): void;
70+
71+
// @public
72+
export function wrappedErrorMessage(e: Error): RegExp;
73+
74+
// (No @packageDocumentation comment for this package)
75+
76+
```

‎goldens/material/datepicker/index.api.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { AfterViewInit } from '@angular/core';
1212
import { ChangeDetectorRef } from '@angular/core';
1313
import { ComponentType } from '@angular/cdk/portal';
1414
import { ControlValueAccessor } from '@angular/forms';
15-
import { DateAdapter } from '@angular/material/core';
1615
import { Directionality } from '@angular/cdk/bidi';
1716
import { DoCheck } from '@angular/core';
1817
import { ElementRef } from '@angular/core';
@@ -701,7 +700,7 @@ export class MatMonthView<D> implements AfterContentInit, OnChanges, OnDestroy {
701700
_comparisonRangeStart: number | null;
702701
comparisonStart: D | null;
703702
// (undocumented)
704-
_dateAdapter: DateAdapter_2<D, any>;
703+
_dateAdapter: DateAdapter<D, any>;
705704
dateClass: MatCalendarCellClassFunction<D>;
706705
dateFilter: (date: D) => boolean;
707706
_dateSelected(event: MatCalendarUserEvent<number>): void;
@@ -759,7 +758,7 @@ export class MatMultiYearView<D> implements AfterContentInit, OnDestroy {
759758
set activeDate(value: D);
760759
readonly activeDateChange: EventEmitter<D>;
761760
// (undocumented)
762-
_dateAdapter: DateAdapter_2<D, any>;
761+
_dateAdapter: DateAdapter<D, any>;
763762
dateClass: MatCalendarCellClassFunction<D>;
764763
dateFilter: (date: D) => boolean;
765764
_focusActiveCell(): void;
@@ -848,7 +847,7 @@ export class MatYearView<D> implements AfterContentInit, OnDestroy {
848847
// (undocumented)
849848
readonly _changeDetectorRef: ChangeDetectorRef;
850849
// (undocumented)
851-
_dateAdapter: DateAdapter_2<D, any>;
850+
_dateAdapter: DateAdapter<D, any>;
852851
dateClass: MatCalendarCellClassFunction<D>;
853852
dateFilter: (date: D) => boolean;
854853
_focusActiveCell(): void;

‎goldens/material/list/index.api.md

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@ import { ElementRef } from '@angular/core';
1111
import { EventEmitter } from '@angular/core';
1212
import * as i0 from '@angular/core';
1313
import * as i1 from '@angular/cdk/bidi';
14-
import * as i12 from '@angular/material/divider';
1514
import * as i2 from '@angular/cdk/observers';
1615
import { InjectionToken } from '@angular/core';
17-
import { MatDivider } from '@angular/material/divider';
1816
import { NgZone } from '@angular/core';
1917
import { OnChanges } from '@angular/core';
2018
import { OnDestroy } from '@angular/core';
@@ -45,7 +43,17 @@ export class MatActionList extends MatListBase {
4543
static ɵfac: i0.ɵɵFactoryDeclaration<MatActionList, never>;
4644
}
4745

48-
export { MatDivider }
46+
// @public (undocumented)
47+
export class MatDivider {
48+
get inset(): boolean;
49+
set inset(value: BooleanInput);
50+
get vertical(): boolean;
51+
set vertical(value: BooleanInput);
52+
// (undocumented)
53+
static ɵcmp: i0.ɵɵComponentDeclaration<MatDivider, "mat-divider", never, { "vertical": { "alias": "vertical"; "required": false; }; "inset": { "alias": "inset"; "required": false; }; }, {}, never, never, true, never>;
54+
// (undocumented)
55+
static ɵfac: i0.ɵɵFactoryDeclaration<MatDivider, never>;
56+
}
4957

5058
// @public (undocumented)
5159
export class MatList extends MatListBase {
@@ -151,7 +159,7 @@ export class MatListModule {
151159
// (undocumented)
152160
static ɵinj: i0.ɵɵInjectorDeclaration<MatListModule>;
153161
// (undocumented)
154-
static ɵmod: i0.ɵɵNgModuleDeclaration<MatListModule, never, [typeof i2.ObserversModule, typeof MatCommonModule, typeof MatRippleModule, typeof MatPseudoCheckboxModule, typeof MatList, typeof MatActionList, typeof MatNavList, typeof MatSelectionList, typeof MatListItem, typeof MatListOption, typeof MatListSubheaderCssMatStyler, typeof MatListItemAvatar, typeof MatListItemIcon, typeof MatListItemLine, typeof MatListItemTitle, typeof MatListItemMeta], [typeof MatList, typeof MatActionList, typeof MatNavList, typeof MatSelectionList, typeof MatListItem, typeof MatListOption, typeof MatListItemAvatar, typeof MatListItemIcon, typeof MatListSubheaderCssMatStyler, typeof i12.MatDividerModule, typeof MatListItemLine, typeof MatListItemTitle, typeof MatListItemMeta]>;
162+
static ɵmod: i0.ɵɵNgModuleDeclaration<MatListModule, never, [typeof i2.ObserversModule, typeof MatCommonModule, typeof MatRippleModule, typeof MatPseudoCheckboxModule, typeof MatList, typeof MatActionList, typeof MatNavList, typeof MatSelectionList, typeof MatListItem, typeof MatListOption, typeof MatListSubheaderCssMatStyler, typeof MatListItemAvatar, typeof MatListItemIcon, typeof MatListItemLine, typeof MatListItemTitle, typeof MatListItemMeta], [typeof MatList, typeof MatActionList, typeof MatNavList, typeof MatSelectionList, typeof MatListItem, typeof MatListOption, typeof MatListItemAvatar, typeof MatListItemIcon, typeof MatListSubheaderCssMatStyler, typeof MatDividerModule, typeof MatListItemLine, typeof MatListItemTitle, typeof MatListItemMeta]>;
155163
}
156164

157165
// @public (undocumented)

‎src/bazel-tsconfig-build.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
// Bazel either uses "umd" or "esnext". We replicate this here for IDE support.
2727
// https://github.com/bazelbuild/rules_typescript/blob/master/internal/common/tsconfig.bzl#L199
2828
"module": "esnext",
29-
"moduleResolution": "node",
29+
"moduleResolution": "bundler",
3030
"sourceMap": true,
3131
"inlineSources": true,
3232
"target": "es2022",

0 commit comments

Comments
 (0)