build: remove remaining jasmine_node_test and modernize webdriver test

Modernizes the rule to not rely on `rules_webtesting`. Yay.

Author: devversion

src/cdk/testing/BUILD.bazel

@@ -45,6 +45,6 @@ e2e_test_suite(
 webdriver_test(
     name = "webdriver_e2e_tests",
     deps = [
-        "//src/cdk/testing/tests:webdriver_test_sources_legacy",
+        "//src/cdk/testing/tests:webdriver_test_sources",
     ],
 )

src/cdk/testing/tests/webdriver-test.bzl

@@ -1,33 +1,31 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "spec_bundle")
-load("@io_bazel_rules_webtesting//web:web.bzl", "web_test")
+load("//tools:defaults2.bzl", "jasmine_test", "spec_bundle")
 load("//tools/server-test:index.bzl", "server_test")
 
 def webdriver_test(name, deps, tags = [], **kwargs):
     spec_bundle(
         name = "%s_bundle" % name,
         deps = deps,
-        platform = "node",
-        external = ["selenium-webdriver"],
     )
 
-    jasmine_node_test(
+    jasmine_test(
         name = "%s_jasmine_test" % name,
         tags = tags + ["manual"],
-        deps = ["%s_bundle" % name, "@npm//selenium-webdriver"],
+        data = [
+            ":%s_bundle" % name,
+            "@npm//@angular/build-tooling/bazel/browsers/chromium",
+        ],
+        env = {
+            "CHROMIUM_BIN": "$(CHROMIUM)",
+            "CHROMEDRIVER": "$(CHROMEDRIVER)",
+        },
+        toolchains = ["@npm//@angular/build-tooling/bazel/browsers/chromium:toolchain_alias"],
         **kwargs
     )
 
-    web_test(
-        name = "%s_chromium_web_test" % name,
-        browser = "@npm//@angular/build-tooling/bazel/browsers/chromium:chromium",
-        tags = tags + ["manual"],
-        test = ":%s_jasmine_test" % name,
-    )
-
     server_test(
         name = "%s_chromium" % name,
         server = "//src/e2e-app:server",
-        test = ":%s_chromium_web_test" % name,
+        test = ":%s_jasmine_test" % name,
         tags = tags + ["e2e"],
     )
 

src/cdk/testing/tests/webdriver.e2e.spec.ts

@@ -3,34 +3,32 @@ import {
   SeleniumWebDriverHarnessEnvironment,
   waitForAngularReady,
 } from '../../testing/selenium-webdriver';
-import {runfiles} from '@bazel/runfiles';
 import * as webdriver from 'selenium-webdriver';
 import {crossEnvironmentSpecs} from './cross-environment.spec';
 import {MainComponentHarness} from './harnesses/main-component-harness';
+import {Options, setDefaultService, ServiceBuilder} from 'selenium-webdriver/chrome';
+import path from 'path';
 
 // Tests are flaky on CI unless we increase the timeout.
 jasmine.DEFAULT_TIMEOUT_INTERVAL = 10_000; // 10 seconds
 
-/**
- * Metadata file generated by `rules_webtesting` for browser tests.
- * The metadata provides configuration for launching the browser and
- * necessary capabilities. See source for details:
- * https://github.com/bazelbuild/rules_webtesting/blob/06023bb3/web/internal/metadata.bzl#L69-L82
- */
-interface WebTestMetadata {
-  capabilities: webdriver.Capabilities;
-}
-
-if (process.env['WEB_TEST_METADATA'] === undefined) {
+if (process.env['TEST_SERVER_PORT'] === undefined) {
   console.error(`Test running outside of a "web_test" target. No browser found.`);
   process.exit(1);
 }
 
-const webTestMetadata: WebTestMetadata = require(
-  runfiles.resolve(process.env['WEB_TEST_METADATA']),
-);
+const projectRoot = path.resolve(__dirname, '../../../');
 const port = process.env['TEST_SERVER_PORT'];
 
+const chromeDriver = path.join(projectRoot, process.env['CHROMEDRIVER']!);
+const chromiumBin = path.join(projectRoot, process.env['CHROMIUM_BIN']!);
+
+setDefaultService(
+  new ServiceBuilder(chromeDriver).enableVerboseLogging().loggingTo('/tmp/test.txt').build(),
+);
+
+process.env['CHROMEDRIVER_EXE'] = chromeDriver;
+
 // Kagekiri is available globally in the browser. We declare it here so we can use it in the
 // browser-side script passed to `By.js`.
 declare const kagekiri: {
@@ -52,8 +50,10 @@ describe('WebDriverHarnessEnvironment', () => {
 
   beforeAll(async () => {
     wd = await new webdriver.Builder()
-      .usingServer(process.env['WEB_TEST_WEBDRIVER_SERVER']!)
-      .withCapabilities(webTestMetadata.capabilities)
+      .forBrowser('chrome')
+      .setChromeOptions(
+        new Options().setChromeBinaryPath(chromiumBin).addArguments('--no-sandbox').headless(),
+      )
       .build();
 
     // Ideally we would refresh the page and wait for Angular to stabilize on each test.

tools/defaults.bzl

@@ -9,7 +9,6 @@ load("@npm//@angular/build-tooling/bazel/esbuild:index.bzl", _esbuild = "esbuild
 load("@npm//@angular/build-tooling/bazel/spec-bundling:index.bzl", _spec_bundle = "spec_bundle")
 load("@npm//@angular/build-tooling/bazel/http-server:index.bzl", _http_server = "http_server")
 load("@npm//@angular/build-tooling/bazel:extract_js_module_output.bzl", "extract_js_module_output")
-load("@npm//@bazel/jasmine:index.bzl", _jasmine_node_test = "jasmine_node_test")
 load("@npm//@bazel/protractor:index.bzl", _protractor_web_test_suite = "protractor_web_test_suite")
 load("//:packages.bzl", "NO_STAMP_NPM_PACKAGE_SUBSTITUTIONS", "NPM_PACKAGE_SUBSTITUTIONS")
 load("//:pkg-externals.bzl", "PKG_EXTERNALS")
@@ -142,10 +141,6 @@ def pkg_npm(name, visibility = None, **kwargs):
         visibility = visibility,
     )
 
-def jasmine_node_test(**kwargs):
-    kwargs["templated_args"] = ["--bazel_patch_module_resolver"] + kwargs.get("templated_args", [])
-    _jasmine_node_test(**kwargs)
-
 def protractor_web_test_suite(name, deps, **kwargs):
     spec_bundle(
         name = "%s_bundle" % name,

tools/defaults2.bzl

@@ -3,9 +3,11 @@ load("//tools/bazel:ts_project_interop.bzl", _ts_project = "ts_project")
 load("//tools/bazel:module_name.bzl", "compute_module_name")
 load("@aspect_rules_js//npm:defs.bzl", _npm_package = "npm_package")
 load("@rules_angular//src/ng_project:index.bzl", _ng_project = "ng_project")
-load("@devinfra//bazel/spec-bundling:index_rjs.bzl", "spec_bundle_amd")
+load("@devinfra//bazel/spec-bundling:index_rjs.bzl", "spec_bundle_amd", _spec_bundle = "spec_bundle")
 load("@devinfra//bazel/karma:index.bzl", _karma_web_test_suite = "karma_web_test_suite")
 
+spec_bundle = _spec_bundle
+
 def npm_package(**kwargs):
     _npm_package(**kwargs)
 
@@ -62,16 +64,14 @@ def jasmine_test(data = [], args = [], **kwargs):
     _jasmine_test(
         node_modules = "//:node_modules",
         chdir = native.package_name(),
-        args = [
+        fixed_args = [
             "--require=%s/node_modules/source-map-support/register.js" % relative_to_root,
             "**/*spec.js",
             "**/*spec.mjs",
             "**/*spec.cjs",
         ] + args,
         data = data + [
             "//:node_modules/source-map-support",
-            # Needed to ensure code is recognized as ESM.
-            "//src:package_json",
         ],
         **kwargs
     )

tools/markdown-to-html/BUILD.bazel

@@ -1,6 +1,5 @@
 load("@aspect_rules_js//js:defs.bzl", "js_binary")
-load("//tools:defaults.bzl", "jasmine_node_test")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults2.bzl", "jasmine_test", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -45,8 +44,8 @@ ts_project(
     ],
 )
 
-jasmine_node_test(
+jasmine_test(
     name = "unit_tests",
-    srcs = [":unit_test_lib_legacy"],
+    data = [":unit_test_lib"],
     visibility = ["//visibility:private"],
 )