Skip to content

Commit 3806c71

Browse files
crisbetocrisbeto
committed
test(multiple): add more time parsing tests
Adds some more tests for the logic that compares times to ensure that they don't consider the date.
1 parent 24762d2 commit 3806c71

File tree

4 files changed

+39
-28
lines changed

4 files changed

+39
-28
lines changed

‎src/material-date-fns-adapter/adapter/date-fns-adapter.spec.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -549,23 +549,25 @@ describe('DateFnsAdapter', () => {
549549
});
550550

551551
it('should compare times', () => {
552-
const base = [2024, JAN, 1] as const;
552+
// Use different dates to guarantee that we only compare the times.
553+
const aDate = [2024, JAN, 1] as const;
554+
const bDate = [2024, FEB, 7] as const;
553555

554556
expect(
555-
adapter.compareTime(new Date(...base, 12, 0, 0), new Date(...base, 13, 0, 0)),
557+
adapter.compareTime(new Date(...aDate, 12, 0, 0), new Date(...bDate, 13, 0, 0)),
556558
).toBeLessThan(0);
557559
expect(
558-
adapter.compareTime(new Date(...base, 12, 50, 0), new Date(...base, 12, 51, 0)),
560+
adapter.compareTime(new Date(...aDate, 12, 50, 0), new Date(...bDate, 12, 51, 0)),
559561
).toBeLessThan(0);
560-
expect(adapter.compareTime(new Date(...base, 1, 2, 3), new Date(...base, 1, 2, 3))).toBe(0);
562+
expect(adapter.compareTime(new Date(...aDate, 1, 2, 3), new Date(...bDate, 1, 2, 3))).toBe(0);
561563
expect(
562-
adapter.compareTime(new Date(...base, 13, 0, 0), new Date(...base, 12, 0, 0)),
564+
adapter.compareTime(new Date(...aDate, 13, 0, 0), new Date(...bDate, 12, 0, 0)),
563565
).toBeGreaterThan(0);
564566
expect(
565-
adapter.compareTime(new Date(...base, 12, 50, 11), new Date(...base, 12, 50, 10)),
567+
adapter.compareTime(new Date(...aDate, 12, 50, 11), new Date(...bDate, 12, 50, 10)),
566568
).toBeGreaterThan(0);
567569
expect(
568-
adapter.compareTime(new Date(...base, 13, 0, 0), new Date(...base, 10, 59, 59)),
570+
adapter.compareTime(new Date(...aDate, 13, 0, 0), new Date(...bDate, 10, 59, 59)),
569571
).toBeGreaterThan(0);
570572
});
571573

‎src/material-luxon-adapter/adapter/luxon-date-adapter.spec.ts

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -657,25 +657,30 @@ describe('LuxonDateAdapter', () => {
657657
});
658658

659659
it('should compare times', () => {
660-
const base = [2024, JAN, 1] as const;
660+
// Use different dates to guarantee that we only compare the times.
661+
const aDate = [2024, JAN, 1] as const;
662+
const bDate = [2024, FEB, 7] as const;
661663

662664
expect(
663-
adapter.compareTime(DateTime.local(...base, 12, 0, 0), DateTime.local(...base, 13, 0, 0)),
665+
adapter.compareTime(DateTime.local(...aDate, 12, 0, 0), DateTime.local(...bDate, 13, 0, 0)),
664666
).toBeLessThan(0);
665667
expect(
666-
adapter.compareTime(DateTime.local(...base, 12, 50, 0), DateTime.local(...base, 12, 51, 0)),
668+
adapter.compareTime(DateTime.local(...aDate, 12, 50, 0), DateTime.local(...bDate, 12, 51, 0)),
667669
).toBeLessThan(0);
668670
expect(
669-
adapter.compareTime(DateTime.local(...base, 1, 2, 3), DateTime.local(...base, 1, 2, 3)),
671+
adapter.compareTime(DateTime.local(...aDate, 1, 2, 3), DateTime.local(...bDate, 1, 2, 3)),
670672
).toBe(0);
671673
expect(
672-
adapter.compareTime(DateTime.local(...base, 13, 0, 0), DateTime.local(...base, 12, 0, 0)),
674+
adapter.compareTime(DateTime.local(...aDate, 13, 0, 0), DateTime.local(...bDate, 12, 0, 0)),
673675
).toBeGreaterThan(0);
674676
expect(
675-
adapter.compareTime(DateTime.local(...base, 12, 50, 11), DateTime.local(...base, 12, 50, 10)),
677+
adapter.compareTime(
678+
DateTime.local(...aDate, 12, 50, 11),
679+
DateTime.local(...bDate, 12, 50, 10),
680+
),
676681
).toBeGreaterThan(0);
677682
expect(
678-
adapter.compareTime(DateTime.local(...base, 13, 0, 0), DateTime.local(...base, 10, 59, 59)),
683+
adapter.compareTime(DateTime.local(...aDate, 13, 0, 0), DateTime.local(...bDate, 10, 59, 59)),
679684
).toBeGreaterThan(0);
680685
});
681686

‎src/material-moment-adapter/adapter/moment-date-adapter.spec.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -639,23 +639,25 @@ describe('MomentDateAdapter', () => {
639639
});
640640

641641
it('should compare times', () => {
642-
const base = [2024, JAN, 1] as const;
642+
// Use different dates to guarantee that we only compare the times.
643+
const aDate = [2024, JAN, 1] as const;
644+
const bDate = [2024, FEB, 7] as const;
643645

644646
expect(
645-
adapter.compareTime(moment([...base, 12, 0, 0]), moment([...base, 13, 0, 0])),
647+
adapter.compareTime(moment([...aDate, 12, 0, 0]), moment([...bDate, 13, 0, 0])),
646648
).toBeLessThan(0);
647649
expect(
648-
adapter.compareTime(moment([...base, 12, 50, 0]), moment([...base, 12, 51, 0])),
650+
adapter.compareTime(moment([...aDate, 12, 50, 0]), moment([...bDate, 12, 51, 0])),
649651
).toBeLessThan(0);
650-
expect(adapter.compareTime(moment([...base, 1, 2, 3]), moment([...base, 1, 2, 3]))).toBe(0);
652+
expect(adapter.compareTime(moment([...aDate, 1, 2, 3]), moment([...bDate, 1, 2, 3]))).toBe(0);
651653
expect(
652-
adapter.compareTime(moment([...base, 13, 0, 0]), moment([...base, 12, 0, 0])),
654+
adapter.compareTime(moment([...aDate, 13, 0, 0]), moment([...bDate, 12, 0, 0])),
653655
).toBeGreaterThan(0);
654656
expect(
655-
adapter.compareTime(moment([...base, 12, 50, 11]), moment([...base, 12, 50, 10])),
657+
adapter.compareTime(moment([...aDate, 12, 50, 11]), moment([...bDate, 12, 50, 10])),
656658
).toBeGreaterThan(0);
657659
expect(
658-
adapter.compareTime(moment([...base, 13, 0, 0]), moment([...base, 10, 59, 59])),
660+
adapter.compareTime(moment([...aDate, 13, 0, 0]), moment([...bDate, 10, 59, 59])),
659661
).toBeGreaterThan(0);
660662
});
661663

‎src/material/core/datetime/native-date-adapter.spec.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -605,23 +605,25 @@ describe('NativeDateAdapter', () => {
605605
});
606606

607607
it('should compare times', () => {
608-
const base = [2024, JAN, 1] as const;
608+
// Use different dates to guarantee that we only compare the times.
609+
const aDate = [2024, JAN, 1] as const;
610+
const bDate = [2024, FEB, 7] as const;
609611

610612
expect(
611-
adapter.compareTime(new Date(...base, 12, 0, 0), new Date(...base, 13, 0, 0)),
613+
adapter.compareTime(new Date(...aDate, 12, 0, 0), new Date(...bDate, 13, 0, 0)),
612614
).toBeLessThan(0);
613615
expect(
614-
adapter.compareTime(new Date(...base, 12, 50, 0), new Date(...base, 12, 51, 0)),
616+
adapter.compareTime(new Date(...aDate, 12, 50, 0), new Date(...bDate, 12, 51, 0)),
615617
).toBeLessThan(0);
616-
expect(adapter.compareTime(new Date(...base, 1, 2, 3), new Date(...base, 1, 2, 3))).toBe(0);
618+
expect(adapter.compareTime(new Date(...aDate, 1, 2, 3), new Date(...bDate, 1, 2, 3))).toBe(0);
617619
expect(
618-
adapter.compareTime(new Date(...base, 13, 0, 0), new Date(...base, 12, 0, 0)),
620+
adapter.compareTime(new Date(...aDate, 13, 0, 0), new Date(...bDate, 12, 0, 0)),
619621
).toBeGreaterThan(0);
620622
expect(
621-
adapter.compareTime(new Date(...base, 12, 50, 11), new Date(...base, 12, 50, 10)),
623+
adapter.compareTime(new Date(...aDate, 12, 50, 11), new Date(...bDate, 12, 50, 10)),
622624
).toBeGreaterThan(0);
623625
expect(
624-
adapter.compareTime(new Date(...base, 13, 0, 0), new Date(...base, 10, 59, 59)),
626+
adapter.compareTime(new Date(...aDate, 13, 0, 0), new Date(...bDate, 10, 59, 59)),
625627
).toBeGreaterThan(0);
626628
});
627629

0 commit comments

Comments
 (0)