Standardise changing create menu title

Author: andrews05

Plug-Ins/Dialog Editor/DialogEditorWindowController.swift

@@ -12,6 +12,7 @@ class DialogEditorWindowController: AbstractEditor, ResourceEditor {
     ]
 
     let resource: Resource
+    let createMenuTitle: String? = "Add Dialog Item"
     private let manager: RFEditorManager
     @IBOutlet var documentView: DITLDocumentView!
     @IBOutlet var tabView: NSTabView!
@@ -150,17 +151,6 @@ class DialogEditorWindowController: AbstractEditor, ResourceEditor {
         self.setDocumentEdited(false)
     }
 
-    
-    func windowDidBecomeKey(_ notification: Notification) {
-        let createItem = NSApp.mainMenu?.item(withTag: 3)?.submenu?.item(withTag: 0)
-        createItem?.title = NSLocalizedString("Create New Item", comment: "")
-    }
-    
-    func windowDidResignKey(_ notification: Notification) {
-        let createItem = NSApp.mainMenu?.item(withTag: 3)?.submenu?.item(withTag: 0)
-        createItem?.title = NSLocalizedString("Create New Resource…", comment: "")
-    }
-    
     override func selectAll(_ sender: Any?) {
         itemList.selectAll(sender)
     }

Plug-Ins/Menu Editor/MenuEditorWindowController.swift

@@ -11,6 +11,7 @@ class MenuEditorWindowController: AbstractEditor, ResourceEditor {
 
     @IBOutlet weak var menuTable: NSTableView!
     let resource: Resource
+    let createMenuTitle: String? = "Add Menu Item"
     private let manager: RFEditorManager
     private var fieldEditorForMenuPreview: NSTextView!
 
@@ -249,17 +250,6 @@ class MenuEditorWindowController: AbstractEditor, ResourceEditor {
         self.setDocumentEdited(false)
     }
 
-    
-    func windowDidBecomeKey(_ notification: Notification) {
-        let createItem = NSApp.mainMenu?.item(withTag: 3)?.submenu?.item(withTag: 0)
-        createItem?.title = NSLocalizedString("Create New Item", comment: "menu command for adding menu items to MENUs")
-    }
-    
-    func windowDidResignKey(_ notification: Notification) {
-        let createItem = NSApp.mainMenu?.item(withTag: 3)?.submenu?.item(withTag: 0)
-        createItem?.title = NSLocalizedString("Create New Resource…", comment: "")
-    }
-    
     @IBAction func createNewItem(_ sender: Any?) {
         var selRow = menuTable.selectedRow
         if selRow == -1 {

RFSupport/AbstractEditor.swift

@@ -99,4 +99,18 @@ open class AbstractEditor: NSWindowController, NSWindowDelegate, NSMenuItemValid
             return true
         }
     }
+
+    open func windowDidBecomeKey(_ notification: Notification) {
+        if let createMenuTitle = (self as? ResourceEditor)?.createMenuTitle {
+            let createItem = NSApp.mainMenu?.item(withTag: 3)?.submenu?.item(withTag: 0)
+            createItem?.title = NSLocalizedString(createMenuTitle, comment: "")
+        }
+    }
+
+    open func windowDidResignKey(_ notification: Notification) {
+        if (self as? ResourceEditor)?.createMenuTitle != nil {
+            let createItem = NSApp.mainMenu?.item(withTag: 3)?.submenu?.item(withTag: 0)
+            createItem?.title = NSLocalizedString("New Resource…", comment: "")
+        }
+    }
 }

RFSupport/ResForgePlugin.swift

@@ -2,21 +2,29 @@ import AppKit
 
 /// An editor provides a window for editing or viewing resources of the supported types.
 public protocol ResourceEditor: AbstractEditor {
-    /// The list of resource types that this plugin supports.
+    /// The list of resource types that this editor supports.
     static var supportedTypes: [String] { get }
 
-    var windowTitle: String { get }
+    /// The resource that the editor is editing.
     var resource: Resource { get }
+
+    /// The title of the editor's window. Default implementation provided.
+    var windowTitle: String { get }
+
+    /// The title of the "Create" menu item, if the editor implements the `createNewItem()` function.
+    var createMenuTitle: String? { get }
+
+    /// Initialise the editor with the resource to be edited and the editor manager.
+    /// May return nil if the editor is unable to edit the resource.
     init?(resource: Resource, manager: RFEditorManager)
 
-    // Implementers should declare these @IBAction
+    // Implementers should declare these @IBAction (or @obj)
     func saveResource(_ sender: Any)
     func revertResource(_ sender: Any)
 }
 public extension ResourceEditor  {
-    var windowTitle: String {
-        resource.defaultWindowTitle
-    }
+    var windowTitle: String { resource.defaultWindowTitle }
+    var createMenuTitle: String? { nil }
 }
 
 /// A preview provider allows the document to display a grid view for a supported resource type.

ResForge/Template Editor/TemplateEditor.swift

@@ -11,6 +11,7 @@ class TemplateEditor: AbstractEditor, ResourceEditor {
     static let supportedTypes: [String] = []
 
     let resource: Resource
+    let createMenuTitle: String? = "Insert List Entry"
     let manager: RFEditorManager
     let template: Resource
     private let filter: TemplateFilter.Type?
@@ -169,16 +170,6 @@ class TemplateEditor: AbstractEditor, ResourceEditor {
     @IBAction func itemValueUpdated(_ sender: Any) {
         edited = .user
     }
-
-    func windowDidBecomeKey(_ notification: Notification) {
-        let createItem = NSApp.mainMenu?.item(withTag: 3)?.submenu?.item(withTag: 0)
-        createItem?.title = NSLocalizedString("Create List Entry", comment: "")
-    }
-
-    func windowDidResignKey(_ notification: Notification) {
-        let createItem = NSApp.mainMenu?.item(withTag: 3)?.submenu?.item(withTag: 0)
-        createItem?.title = NSLocalizedString("Create New Resource…", comment: "")
-    }
 }
 
 extension TemplateEditor: NSOutlineViewDelegate, NSOutlineViewDataSource {