Why entries with referencing fields are ignored?

[cristianst85]

Hi,

Is there a specific reason why entries with referencing fields are ignored?

keepass2-haveibeenpwned/HaveIBeenPwned/BreachCheckers/HaveIBeenPwnedPassword/HaveIBeenPwnedPasswordChecker.cs

Line 76 in 56fab5b

if(entry.Strings.Get(PwDefs.PasswordField) == null || string.IsNullOrWhiteSpace(entry.Strings.ReadSafe(PwDefs.PasswordField)) || entry.Strings.ReadSafe(PwDefs.PasswordField).StartsWith("{REF:")) continue;

keepass2-haveibeenpwned/HaveIBeenPwned/BreachCheckers/HaveIBeenPwnedUsername/HaveIBeenPwnedUsernameChecker.cs

Line 70 in 56fab5b

var filteredUsernames = usernames.Where(u => !string.IsNullOrWhiteSpace(u) && !u.StartsWith("{REF:"));

Imho I think at least there should be another checkbox in the dialog window where you could choose whether to resolve them or not.

Also, to improve usability, entries with referencing fields may not be counted/shown in Breached Entries window (or show them, but add extra column, e.g. Has Referencing Field).

Let me know what you think about this and I'll happily submit a PR.

Regards,
Cristian

[andrew-schofield]

If you want to go ahead and create a PR then please do.