Should originalChecksum fields be optional?

[chall-ti]

Hi,
I came across this library today and found it to be very helpful! However, I encountered one minor issue while using it and wanted to mention it here to see if it made sense to request a change or start a pull request:

When calling artifact_info = art.artifacts.info(ARTIFACT_PATH), I receive the following Pydantic validation error:

pydantic_core._pydantic_core.ValidationError: 1 validation error for ArtifactFileInfoResponse
originalChecksums.sha1
  Field required [type=missing, input_value={'md5': 'ef4bdeccdbdf8af2...024eaf8ca5061c0bedb43d'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.11/v/missing

When looking into this error message, I inspected the response.json() and noticed that originalChecksums did not have a sha1 field:
{... 'originalChecksums': {'md5': 'ef4bdeccdbdf8af2d0da9170b8e491f4', 'sha256': '704b68b397edc2a2ba2a3f7704e07f5ff7a3707c0f024eaf8ca5061c0bedb43d'} ...}

As a workaround I modified the OriginalChecksums model from...

class OriginalChecksums(BaseModel):
    ``"""Models original checksums."""

    sha256: str
    sha1: str
    md5: str

...to...

class OriginalChecksums(BaseModel):
    ``"""Models original checksums."""

    sha256: str
    sha1: Optional[str] = None
    md5: str

...and was able to finish my writing a script to download an artifact and verify it's MD5 checksum. However, for future uses it would be nice to not have to implement this monkey patch, hence, thought I'd bring it up for discussion to see if it made sense to request this change.

I tried searching Artifactory REST API to see I could find any additional informational info about the originalChecksums object and its fields to see if the documentation called it out as an optional field, but didn't find anything to address this question. However, I did find this note on StackOverflow:

If the deploying tool is not providing a checksum or provides it in a non standrad way, Artifactory will not have an originalchecksum.
https://stackoverflow.com/questions/35304885/checksum-vs-originalchecksums-in-artifactory-api-response

Perhaps this user error on my part by not uploading the file correctly in the first place?! I'm new Artifactory user and eager to learn from others.

Thanks,
Chris

[chall-ti]

UPDATE: My original files were uploaded using a makeshift PowerShell script. But after using pyartifactory to deploy the artifact, this yielded better results and now I see all of the originalChecksum fields.

[anancarv]

Hey @chall-ti;
This issue has been fixed by making OriginalChecksums field optional #212