Skip to content

Commit ee2645e

Browse files
committed
dt-bindings: pwm: adi,axi-pwmgen: Fix clocks
Fix a shortcoming in the bindings that doesn't allow for a separate external clock. The AXI PWMGEN IP block has a compile option ASYNC_CLK_EN that allows the use of an external clock for the PWM output separate from the AXI clock that runs the peripheral. This was missed in the original bindings and so users were writing dts files where the one and only clock specified would be the external clock, if there was one, incorrectly missing the separate AXI clock. The correct bindings are that the AXI clock is always required and the external clock is optional (must be given only when HDL compile option ASYNC_CLK_EN=1). Fixes: 1edf2c2 ("dt-bindings: pwm: Add AXI PWM generator") Cc: stable@vger.kernel.org Signed-off-by: David Lechner <dlechner@baylibre.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250529-pwm-axi-pwmgen-add-external-clock-v3-2-5d8809a7da91@baylibre.com Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org> (cherry picked from commit e683131) Signed-off-by: David Lechner <dlechner@baylibre.com>
1 parent 9a4c955 commit ee2645e

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,19 @@ properties:
3030
const: 3
3131

3232
clocks:
33-
maxItems: 1
33+
minItems: 1
34+
maxItems: 2
35+
36+
clock-names:
37+
minItems: 1
38+
items:
39+
- const: axi
40+
- const: ext
3441

3542
required:
3643
- reg
3744
- clocks
45+
- clock-names
3846

3947
unevaluatedProperties: false
4048

@@ -43,6 +51,7 @@ examples:
4351
pwm@44b00000 {
4452
compatible = "adi,axi-pwmgen-2.00.a";
4553
reg = <0x44b00000 0x1000>;
46-
clocks = <&spi_clk>;
54+
clocks = <&fpga_clk>, <&spi_clk>;
55+
clock-names = "axi", "ext";
4756
#pwm-cells = <3>;
4857
};

0 commit comments

Comments
 (0)