Update SDK to rev 2021/04/30; Pylint 2.8.2 (#129)

Author: Robert Muchsel

.github/linters/.python-lint

@@ -1,7 +1,7 @@
 [MESSAGES CONTROL]
-disable=invalid-name,fixme,import-error
+disable=invalid-name, consider-using-with, fixme, import-error
 [TYPECHECK]
-ignored-modules = numpy, matplotlib.cm, torch, distiller
+ignored-modules = numpy, matplotlib.cm, torch
 ignored-classes = ModelProto
 [FORMAT]
 max-line-length = 99
@@ -18,4 +18,4 @@ max-public-methods=35
 max-bool-expr=8
 max-parents=15
 [MASTER]
-ignore=CMSIS_5,distiller,sdk
+ignore=CMSIS_5,sdk

.pylintrc

@@ -1,7 +1,7 @@
 [MESSAGES CONTROL]
-disable=invalid-name
+disable=invalid-name, consider-using-with
 [TYPECHECK]
-ignored-modules = numpy, matplotlib.cm, torch, distiller
+ignored-modules = numpy, matplotlib.cm, torch
 ignored-classes = ModelProto
 [FORMAT]
 max-line-length = 99
@@ -18,4 +18,4 @@ max-public-methods=35
 max-bool-expr=8
 max-parents=15
 [MASTER]
-ignore=CMSIS_5,distiller
+ignore=CMSIS_5,sdk

assets/rtlsim-verify-output/verify-output.py

@@ -46,7 +46,7 @@
 
 # Go through all the files in 'data-expected' and read them. For each, make sure there is a
 # corresponding file in 'data-output'. Open that file and make sure that the information matches.
-for _, _, fnames in sorted(os.walk('data-expected')):
+for _, _, fnames in sorted(os.walk('data-expected')):  # type: ignore
     for fname in sorted(fnames):
         outname = fname.replace('DRAM_', 'DRAM_out_')
         if not os.path.isfile(os.path.join('data-output', outname)):
@@ -66,23 +66,23 @@
                 sys.exit(-3)
 
             try:
-                addr = int(addr[1:], base=16)
+                addr = int(addr[1:], base=16)  # type: ignore
                 val = val.strip().lower()
                 mask = ''
-                for _, m in enumerate(val):
+                for _, m in enumerate(val):  # type: ignore
                     mask += '0' if m == 'x' else 'f'
-                mask = int(mask, base=16)
-                val = int(val.replace('x', '0'), base=16)
+                mask = int(mask, base=16)  # type: ignore
+                val = int(val.replace('x', '0'), base=16)  # type: ignore
             except ValueError:
                 log.error('Malformed line %s in file data-expected/%s!', e.strip(), fname)
                 sys.exit(-3)
 
-            if addr > len(data):
+            if addr > len(data):  # type: ignore
                 log.error('Address from %s not present in file data-output/%s!',
                           e.strip(), outname)
                 failures += 1
             else:
-                result = data[addr].strip().lower()
+                result = data[addr].strip().lower()  # type: ignore
                 if result == 'x' * len(result):
                     log.error('Output is %s at address %04x in file data-output/%s!',
                               result, addr, outname)
@@ -93,11 +93,14 @@
                         resultf = int(result.replace('x', 'f'), base=16)
                     except ValueError:
                         log.error('Malformed line %04x: %s in file data-output/%s!',
-                                  addr, data[addr].strip(), fname)
+                                  addr, data[addr].strip(), fname)  # type: ignore
                         sys.exit(-3)
 
                     log.debug('Found address %04x, val %08x, comp %s', addr, val, result)
-                    if result0 & mask != val & mask or resultf & mask != val & mask:
+                    if (
+                        result0 & mask != val & mask  # type: ignore
+                        or resultf & mask != val & mask  # type: ignore
+                       ):
                         log.error('Data mismatch at address %04x in file data-output/%s. '
                                   'Expected: %08x, got %s (mask %08x)!',
                                   addr, outname, val, result, mask)