Correctly handle the error of the getaddrinfo function (#191)

an-tao · web-flow · commit cf5fa83c795b · 2021-12-10T11:56:47.000+08:00
diff --git a/trantor/net/inner/NormalResolver.cc b/trantor/net/inner/NormalResolver.cc
@@ -56,13 +56,13 @@ void NormalResolver::resolve(const std::string &hostname,
                     }
                 }
             }
-            struct addrinfo hints, *res;
+            struct addrinfo hints, *res = nullptr;
             memset(&hints, 0, sizeof(hints));
             hints.ai_family = PF_UNSPEC;
             hints.ai_socktype = SOCK_STREAM;
             hints.ai_flags = AI_PASSIVE;
             auto error = getaddrinfo(hostname.data(), nullptr, &hints, &res);
-            if (error == -1 || res == nullptr)
+            if (error != 0 || res == nullptr)
             {
                 LOG_SYSERR << "InetAddress::resolve";
                 if (res != nullptr)

Original file line number	Diff line number	Diff line change
`@@ -56,13 +56,13 @@ void NormalResolver::resolve(const std::string &hostname,`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`	`}`
`59`		`- struct addrinfo hints, *res;`
	`59`	`+ struct addrinfo hints, *res = nullptr;`
`60`	`60`	`memset(&hints, 0, sizeof(hints));`
`61`	`61`	`hints.ai_family = PF_UNSPEC;`
`62`	`62`	`hints.ai_socktype = SOCK_STREAM;`
`63`	`63`	`hints.ai_flags = AI_PASSIVE;`
`64`	`64`	`auto error = getaddrinfo(hostname.data(), nullptr, &hints, &res);`
`65`		`- if (error == -1 \|\| res == nullptr)`
	`65`	`+ if (error != 0 \|\| res == nullptr)`
`66`	`66`	`{`
`67`	`67`	`LOG_SYSERR << "InetAddress::resolve";`
`68`	`68`	`if (res != nullptr)`