Fix a bug in the splitString() function (#83)

Author: an-tao

trantor/unittests/CMakeLists.txt

@@ -2,7 +2,12 @@ find_package(GTest REQUIRED)
 add_executable(msgbuffer_unittest MsgBufferUnittest.cc)
 add_executable(inetaddress_unittest InetAddressUnittest.cc)
 add_executable(date_unittest DateUnittest.cc)
-set(UNITTEST_TARGETS msgbuffer_unittest inetaddress_unittest date_unittest)
+add_executable(split_string_unittest splitStringUnittest.cc)
+set(UNITTEST_TARGETS
+    msgbuffer_unittest
+    inetaddress_unittest
+    date_unittest
+    split_string_unittest)
 set_property(TARGET ${UNITTEST_TARGETS} PROPERTY CXX_STANDARD 14)
 set_property(TARGET ${UNITTEST_TARGETS} PROPERTY CXX_STANDARD_REQUIRED ON)
 set_property(TARGET ${UNITTEST_TARGETS} PROPERTY CXX_EXTENSIONS OFF)

trantor/unittests/splitStringUnittest.cc

@@ -0,0 +1,48 @@
+#include <trantor/utils/Date.h>
+#include <gtest/gtest.h>
+#include <trantor/utils/Funcs.h>
+#include <iostream>
+using namespace trantor;
+TEST(splitString, split_string)
+{
+    std::string originString = "1,2,3";
+    auto out = splitString(originString, ",");
+    EXPECT_EQ(out.size(), 3);
+    originString = ",1,2,3";
+    out = splitString(originString, ",");
+    EXPECT_EQ(out.size(), 4);
+    EXPECT_TRUE(out[0].empty());
+    originString = ",1,2,3,";
+    out = splitString(originString, ",");
+    EXPECT_EQ(out.size(), 5);
+    EXPECT_TRUE(out[0].empty());
+    originString = ",1,2,3,";
+    out = splitString(originString, ":");
+    EXPECT_EQ(out.size(), 1);
+    originString = "trantor::splitString";
+    out = splitString(originString, "::");
+    EXPECT_EQ(out.size(), 2);
+    EXPECT_STREQ(out[0].data(), "trantor");
+    EXPECT_STREQ(out[1].data(), "splitString");
+    originString = "trantor::::splitString";
+    out = splitString(originString, "::");
+    EXPECT_EQ(out.size(), 3);
+    EXPECT_STREQ(out[0].data(), "trantor");
+    EXPECT_STREQ(out[1].data(), "");
+    EXPECT_STREQ(out[2].data(), "splitString");
+    originString = "trantor:::splitString";
+    out = splitString(originString, "::");
+    EXPECT_EQ(out.size(), 2);
+    EXPECT_STREQ(out[0].data(), "trantor");
+    EXPECT_STREQ(out[1].data(), ":splitString");
+    originString = "trantor:::splitString";
+    out = splitString(originString, "trantor:::splitString");
+    EXPECT_EQ(out.size(), 2);
+    EXPECT_STREQ(out[0].data(), "");
+    EXPECT_STREQ(out[1].data(), "");
+}
+int main(int argc, char **argv)
+{
+    testing::InitGoogleTest(&argc, argv);
+    return RUN_ALL_TESTS();
+}

trantor/utils/Funcs.h

@@ -40,7 +40,7 @@ inline std::vector<std::string> splitString(const std::string &s,
     while ((next = s.find(delimiter, last)) != std::string::npos)
     {
         v.push_back(s.substr(last, next - last));
-        last = next + 1;
+        last = next + delimiter.length();
     }
     v.push_back(s.substr(last));
     return std::move(v);