Merge pull request #26 from an-tao/dev

an-tao · web-flow · commit 910a4f99a5c7 · 2019-05-16T15:24:04.000+08:00
Remove unnecessary 'if' statements
diff --git a/trantor/net/ssl/SSLConnection.cc b/trantor/net/ssl/SSLConnection.cc
@@ -83,15 +83,12 @@ void SSLConnection::readCallback()
                     return;
                 }
             }
-            if (rd > 0)
-            {
-                _readBuffer.hasWritten(rd);
-                newDataFlag = true;
-            }
+            _readBuffer.hasWritten(rd);
+            newDataFlag = true;
         } while ((size_t)rd == readLength);
         if (newDataFlag)
         {
-            //eval callback function;
+            //Run callback function
             _recvMsgCallback(shared_from_this(), &_readBuffer);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -83,15 +83,12 @@ void SSLConnection::readCallback()`
`83`	`83`	`return;`
`84`	`84`	`}`
`85`	`85`	`}`
`86`		`- if (rd > 0)`
`87`		`- {`
`88`		`- _readBuffer.hasWritten(rd);`
`89`		`- newDataFlag = true;`
`90`		`- }`
	`86`	`+ _readBuffer.hasWritten(rd);`
	`87`	`+ newDataFlag = true;`
`91`	`88`	`} while ((size_t)rd == readLength);`
`92`	`89`	`if (newDataFlag)`
`93`	`90`	`{`
`94`		`- //eval callback function;`
	`91`	`+ //Run callback function`
`95`	`92`	`_recvMsgCallback(shared_from_this(), &_readBuffer);`
`96`	`93`	`}`
`97`	`94`	`}`