Make the std::string_view work on windows (#256)

an-tao · web-flow · commit 8abea09d1eb2 · 2023-05-29T23:17:15.000+08:00
diff --git a/trantor/utils/LogStream.h b/trantor/utils/LogStream.h
@@ -22,7 +22,7 @@
 #include <string.h>  // memcpy
 #include <string>
 
-#if __cplusplus >= 201703L
+#if __cplusplus >= 201703L || (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)
 #include <string_view>
 #endif
 
@@ -204,10 +204,10 @@ class TRANTOR_EXPORT LogStream : NonCopyable
         append(v.c_str(), v.size());
         return *this;
     }
-#if __cplusplus >= 201703L
+#if __cplusplus >= 201703L || (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)
     self &operator<<(const std::string_view v)
     {
-        append(v.begin(), v.size());
+        append(v.data(), v.length());
         return *this;
     }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`#include <string.h> // memcpy`
`23`	`23`	`#include <string>`
`24`	`24`
`25`		`-#if __cplusplus >= 201703L`
	`25`	`+#if __cplusplus >= 201703L \|\| (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)`
`26`	`26`	`#include <string_view>`
`27`	`27`	`#endif`
`28`	`28`
`@@ -204,10 +204,10 @@ class TRANTOR_EXPORT LogStream : NonCopyable`
`204`	`204`	`append(v.c_str(), v.size());`
`205`	`205`	`return *this;`
`206`	`206`	`}`
`207`		`-#if __cplusplus >= 201703L`
	`207`	`+#if __cplusplus >= 201703L \|\| (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)`
`208`	`208`	`self &operator<<(const std::string_view v)`
`209`	`209`	`{`
`210`		`- append(v.begin(), v.size());`
	`210`	`+ append(v.data(), v.length());`
`211`	`211`	`return *this;`
`212`	`212`	`}`
`213`	`213`	`#endif`