GNU: -Wall -Wextra -Werror; fix related warnings (#143)

Author: pkovacs

CMakeLists.txt

@@ -41,6 +41,10 @@ else(BUILD_TRANTOR_SHARED)
   add_library(${PROJECT_NAME} STATIC)
 endif(BUILD_TRANTOR_SHARED)
 
+if (CMAKE_CXX_COMPILER_ID MATCHES GNU)
+    target_compile_options(${PROJECT_NAME} PRIVATE -Wall -Wextra -Werror)
+endif()
+
 include(GenerateExportHeader)
 generate_export_header(${PROJECT_NAME} EXPORT_FILE_NAME ${CMAKE_CURRENT_BINARY_DIR}/exports/trantor/exports.h)
 

trantor/net/EventLoop.cc

@@ -68,12 +68,11 @@ EventLoop::EventLoop()
       currentActiveChannel_(nullptr),
       eventHandling_(false),
       timerQueue_(new TimerQueue(this)),
-      threadLocalLoopPtr_(&t_loopInThisThread)
 #ifdef __linux__
-      ,
       wakeupFd_(createEventfd()),
-      wakeupChannelPtr_(new Channel(this, wakeupFd_))
+      wakeupChannelPtr_(new Channel(this, wakeupFd_)),
 #endif
+      threadLocalLoopPtr_(&t_loopInThisThread)
 {
     if (t_loopInThisThread)
     {
@@ -305,10 +304,12 @@ void EventLoop::wakeup()
     uint64_t tmp = 1;
 #ifdef __linux__
     int ret = write(wakeupFd_, &tmp, sizeof(tmp));
+    (void)ret;
 #elif defined _WIN32
     poller_->postEvent(1);
 #else
     int ret = write(wakeupFd_[1], &tmp, sizeof(tmp));
+    (void)ret;
 #endif
 }
 void EventLoop::wakeupRead()

trantor/net/inner/NormalResolver.cc

@@ -12,7 +12,7 @@
 
 using namespace trantor;
 
-std::shared_ptr<Resolver> Resolver::newResolver(trantor::EventLoop *loop,
+std::shared_ptr<Resolver> Resolver::newResolver(trantor::EventLoop *,
                                                 size_t timeout)
 {
     return std::make_shared<NormalResolver>(timeout);

trantor/net/inner/TcpConnectionImpl.cc

@@ -1430,7 +1430,7 @@ void TcpConnectionImpl::sendFileInLoop(const BufferNodePtr &filePtr)
             {
                 filePtr->fileBytesToSend_ -= nSend;
                 filePtr->offset_ += static_cast<off_t>(nSend);
-                if (static_cast<size_t>(nSend) < n)
+                if (static_cast<size_t>(nSend) < static_cast<size_t>(n))
                 {
                     if (!ioChannelPtr_->isWriting())
                     {
@@ -1559,12 +1559,12 @@ TcpConnectionImpl::TcpConnectionImpl(EventLoop *loop,
                                      bool isServer,
                                      bool validateCert,
                                      const std::string &hostname)
-    : loop_(loop),
+    : isEncrypted_(true),
+      loop_(loop),
       ioChannelPtr_(new Channel(loop, socketfd)),
       socketPtr_(new Socket(socketfd)),
       localAddr_(localAddr),
-      peerAddr_(peerAddr),
-      isEncrypted_(true)
+      peerAddr_(peerAddr)
 {
     LOG_TRACE << "new connection:" << peerAddr.toIpPort() << "->"
               << localAddr.toIpPort();

trantor/net/inner/TimerQueue.cc

@@ -65,7 +65,7 @@ static void resetTimerfd(int timerfd, const TimePoint &expiration)
         // LOG_SYSERR << "timerfd_settime()";
     }
 }
-static void readTimerfd(int timerfd, const TimePoint &now)
+static void readTimerfd(int timerfd, const TimePoint &)
 {
     uint64_t howmany;
     ssize_t n = ::read(timerfd, &howmany, sizeof howmany);