Title Bar Colors should take into consideration FluentTheme.CustomAccentColor

[Abdo-reda]

Is your feature request related to a problem? Please describe.
The Title Bar Colors (MinMaxClose Controls) Use the System Accent Color if its available and ignores the CustomAccentColor if its set. As a result, if the application depends and uses the CustomAccentColor then there is a color mismatch (the application is using a color that is different from the title bar controls colors).

Describe the solution you'd like
I think the Function that sets the title bar colors private void SetTitleBarColors() should prioritize and use the CustomAccentColor if found, if not found then it should fallback to the current behavior.

Describe alternatives you've considered
We could also introduce a variable or configuration whether the titlebar colors should depend on the custom accent color or not. This will give the option so that if some developers want the title bar colors to depend on the system color and ignore the CustomAccentColor.

Additional context

• SetTitleBarColors
• An image showing what it could look like (minimize button) vs current behaviour (max and close buttons).
  

[Abdo-reda]

Update: I just noticed that LoadCustomAccentColor is called to set the custom accent color, which then calls UpdateAccentColors which updates the resource dictionary { "SystemAccentColor", accent }. Maybe the LoadCustomAccentColor is called after the title bar colors have been set? I am not sure. In this case, this is more likely a bug than a feature request.

[timunie]

you may want to try creating a PR and see if it solves your issue. I'm not a maintainer here, but from the past I can say that often bug fixes are accepted.

[amwx]

Can you provide a minimal repro of this? On my end I am not seeing issues with using a custom accent color and the caption buttons. Granted I'm testing this on a branch that's up to Avalonia 11.2.5 so its also possible something upstream is causing this issue that has been fixed. Regardless, I need a minimal repro here

[Abdo-reda]

Sounds reasonable, when I am free, I will try and reproduce it and link the repo here 👍