Skip to content

Commit 3133d88

Browse files
committed
update github workflow and fix build app issue
1 parent 762d2be commit 3133d88

File tree

4 files changed

+7
-17
lines changed

4 files changed

+7
-17
lines changed

.eslintrc.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,7 @@ module.exports = {
3131
'react',
3232
],
3333
rules: {
34-
// 'no-console': 'off', // Warns about console.log statements
35-
// 'react/prop-types': 'off', // Turns off prop-types rule for React
3634
'comma-dangle': ['error', 'always-multiline'], // Enforces trailing commas for multiline statements
37-
// 'prefer-const': 'error', // Requires that developers use const for variables that are never reassigned after declared
38-
// 'react/jsx-uses-react': 'error', // Prevents React to be incorrectly marked as unused
39-
// 'react/jsx-uses-vars': 'error', // Prevents variables used in JSX to be incorrectly marked as unused
40-
// 'react-hooks/rules-of-hooks': 'off', // Checks rules of Hooks
41-
// 'react-hooks/exhaustive-deps': 'off', // Checks effect dependencies
42-
// 'no-mixed-operators': 'off', // Allows mixed operators
43-
// 'no-void': 'off', // Allows void operator
44-
// 'no-return-assign': 'off', // Allows return statements to be used in the value position of assignments
45-
// 'no-unused-expressions': 'off', // Allows unused expressions
46-
// 'no-sequences': 'off', // Allows comma operator
47-
// 'no-var': 'off', // Requires that var is not used
4835
'react/jsx-filename-extension': ['warn', { extensions: ['.js', '.jsx'] }], // Enforces .jsx extension for JSX files
4936
'react/react-in-jsx-scope': 'off', // Prevents React to be incorrectly marked as unused
5037
},

.github/workflows/workflow_backend.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ jobs:
3232
- name: Install Dependencies
3333
run: npm install --prefix backend
3434

35+
- name: Run ESLint
36+
run: npx eslint . --ext .js
37+
3538
- name: Run Tests
3639
run: npm test --prefix backend
3740

.github/workflows/workflow_frontend.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ jobs:
3030
- name: Install Dependencies
3131
run: npm install --prefix frontend
3232

33-
# - name: Build
34-
# run: npm run build --prefix frontend
33+
- name: Run ESLint
34+
run: npx eslint . --ext .js,.jsx
3535

36-
# - name: Test
37-
# run: npm test --prefix frontend
36+
- name: Build
37+
run: npm run build

0 commit comments

Comments
 (0)