Skip to content

Commit fa26938

Browse files
authored
Merge pull request #2 from aminya/msvc-fix
2 parents e9a591d + ed2713e commit fa26938

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/msvc/msvc.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,19 +43,19 @@ export async function setupMSVC(
4343
exportVariable("VCTargetsPath", VCTargetsPath)
4444
}
4545
} else if (version === "2017") {
46-
toolset = "15.9.38.0"
47-
await setupChocoPack("visualstudio2017buildtools", toolset, [
46+
toolset = "14.16"
47+
await setupChocoPack("visualstudio2017buildtools", "15.9.38.0", [
4848
"--package-parameters",
49-
"add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive",
49+
"'--add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive'",
5050
])
51-
VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/MSBuild/Microsoft/VC/v150"
51+
VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.16" // TODO verify path
5252
} else if (version === "2019") {
53-
toolset = "16.11.2.0"
54-
await setupChocoPack("visualstudio2019buildtools", toolset, [
53+
toolset = "14.29.30133"
54+
await setupChocoPack("visualstudio2019buildtools", "16.11.2.0", [
5555
"--package-parameters",
56-
"add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive",
56+
"'--add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive'",
5757
])
58-
VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/MSBuild/Microsoft/VC/v160"
58+
VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133"
5959
}
6060
if (VCTargetsPath !== undefined && existsSync(VCTargetsPath)) {
6161
exportVariable("VCTargetsPath", VCTargetsPath)

0 commit comments

Comments
 (0)