feat: check if update-notifier is installed before using it

Author: aminya

package.json

@@ -63,6 +63,8 @@
     "update-notifier": "^5.1.0"
   },
   "devDependencies": {
+    "@types/resolve": "^1.20.2",
+    "resolve": "^1.22.2",
     "@actions/core": "^1.10.0",
     "@actions/exec": "^1.1.1",
     "@actions/io": "^1.1.3",

pnpm-lock.yaml

@@ -2,21 +2,26 @@ import { warning } from "ci-log"
 import { promises } from "fs"
 const { readFile } = promises
 import { join } from "path"
+import { isInstalled } from "./utils/std/resolve"
 
 // auto self update notifier
 export async function checkUpdates() {
   try {
-    const [un, packageJsonString] = await Promise.all([
-      import("update-notifier"),
-      readFile(join(__dirname, "..", "package.json"), "utf8"),
-    ])
+    if (await isInstalled("update-notifier")) {
+      const [un, packageJsonString] = await Promise.all([
+        import("update-notifier"),
+        readFile(join(__dirname, "..", "package.json"), "utf8"),
+      ])
 
-    const packageJson = JSON.parse(packageJsonString)
+      const packageJson = JSON.parse(packageJsonString)
 
-    // the types do not match the actual export
-    const updateNotifier = un as unknown as (typeof un)["default"]
+      // the types do not match the actual export
+      const updateNotifier = un as unknown as (typeof un)["default"]
 
-    updateNotifier({ pkg: packageJson }).notify()
+      updateNotifier({ pkg: packageJson }).notify()
+    } else {
+      warning("setup-cpp could not find its dependency update-notifier, skipping check for updates")
+    }
   } catch (err) {
     warning(`Failed to check for updates: ${err instanceof Error ? err.message + err.stack : err}`)
   }

src/check-updates.ts

@@ -0,0 +1,31 @@
+import resolveCb from "resolve"
+
+interface PackageMeta {
+  name: string
+  version: string
+  [key: string]: any
+}
+
+/** Promise wrapper for resolve */
+export async function resolve(id: string): Promise<{ resolved: string; pkg?: PackageMeta }> {
+  return new Promise((resolve, reject) => {
+    resolveCb(id, (err, resolved, pkg) => {
+      if (err) {
+        reject(err)
+      } else if (resolved === undefined) {
+        reject(new Error(`Could not resolve ${id}`))
+      } else {
+        resolve({ resolved, pkg })
+      }
+    })
+  })
+}
+
+export async function isInstalled(id: string) {
+    try {
+        await resolve(id)
+        return true
+    } catch {
+        return false
+    }
+}