Skip to content

Commit dd02c2e

Browse files
committed
fix: use sh for the entry point in docker
1 parent 07b2187 commit dd02c2e

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ RUN chmod +x ./setup_cpp_linux
147147
# install llvm, cmake, ninja, ccache, and conan
148148
RUN ./setup_cpp_linux --compiler llvm --cmake true --ninja true --ccache true --conan true
149149

150-
ENTRYPOINT [ "/bin/bash" ]
150+
ENTRYPOINT [ "/bin/sh" ]
151151
```
152152

153153
See [this folder](https://github.com/aminya/setup-cpp/tree/master/building/docker), for some dockerfile examples.
@@ -158,7 +158,13 @@ If you want to build the ones included, then run:
158158
docker build -f ./building/docker/debian.dockerfile -t setup_cpp .
159159
```
160160

161-
After `-f` use the docker file name.
161+
Where you should use the path to the the docker after `-f`.
162+
163+
After build, run the following to start an interactive shell in your container
164+
165+
```ps1
166+
docker run -it setup_cpp
167+
```
162168

163169
### Incomplete
164170

building/docker/debian.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ RUN chmod +x ./setup_cpp_linux
1212
# install llvm, cmake, ninja, ccache, and conan
1313
RUN ./setup_cpp_linux --compiler llvm --cmake true --ninja true --ccache true --conan true
1414

15-
ENTRYPOINT [ "/bin/bash" ]
15+
ENTRYPOINT [ "/bin/sh" ]

building/docker/debian_node.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ WORKDIR "/"
88
# run installation
99
RUN node ./setup_cpp.js --compiler llvm --cmake true --ninja true --ccache true --conan true
1010

11-
ENTRYPOINT [ "/bin/bash" ]
11+
ENTRYPOINT [ "/bin/sh" ]

dist/setup_cpp.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/setup_cpp.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)