chore: improve the types for setups and tools

Author: aminya

src/default_versions.ts

@@ -15,6 +15,6 @@ export function getVersion(name: string, version: string | undefined) {
   if (version === "true" || (version === undefined && name in DefaultVersions)) {
     return DefaultVersions[name]
   } else {
-    return version
+    return version ?? ""
   }
 }

src/main.ts

@@ -16,10 +16,27 @@ import { setupPython } from "./python/python"
 
 import semverValid from "semver/functions/valid"
 import { getVersion } from "./default_versions"
-import { InstallationInfo } from "./utils/setup/setupBin"
 import { setupGcc } from "./gcc/gcc"
 
-const tools = [
+const setups = {
+  cmake: setupCmake,
+  ninja: setupNinja,
+  python: setupPython,
+  conan: setupConan,
+  meson: setupMeson,
+  gcovr: setupGcovr,
+  opencppcoverage: setupOpencppcoverage,
+  llvm: setupLLVM,
+  gcc: setupGcc,
+  choco: setupChocolatey,
+  brew: setupBrew,
+  ccache: setupCcache,
+  doxygen: setupDoxygen,
+  cppcheck: setupCppcheck,
+  msvc: setupMSVC,
+}
+
+const tools: Array<keyof typeof setups> = [
   "cmake",
   "ninja",
   "python",
@@ -37,32 +54,9 @@ const tools = [
   "msvc",
 ]
 
-const setups = {
-  cmake: setupCmake,
-  ninja: setupNinja,
-  python: setupPython,
-  conan: setupConan,
-  meson: setupMeson,
-  gcovr: setupGcovr,
-  opencppcoverage: setupOpencppcoverage,
-  llvm: setupLLVM,
-  gcc: setupGcc,
-  choco: setupChocolatey,
-  brew: setupBrew,
-  ccache: setupCcache,
-  doxygen: setupDoxygen,
-  cppcheck: setupCppcheck,
-  msvc: setupMSVC,
-} as Record<
-  string,
-  (
-    version: string | undefined,
-    setupCppDir: string,
-    ...args: unknown[]
-  ) => Promise<InstallationInfo> | Promise<void> | void
->
+type Inputs = "compiler" | keyof typeof setups
 
-function maybeGetInput(key: string) {
+function maybeGetInput(key: Inputs) {
   const value = core.getInput(key.toLowerCase())
   if (value !== "false" && value !== "") {
     return value
@@ -131,10 +125,12 @@ export async function main(): Promise<number> {
           // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
           if (installationInfo !== undefined) {
             let success = `${tool} was successfully installed`
-            if (installationInfo.installDir !== undefined) {
+            if ("installDir" in installationInfo) {
+              // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+              // @ts-ignore typescript is confused about the existence of installDir
               success += `\nThe installation direcotry is ${installationInfo.installDir}`
             }
-            if (installationInfo.binDir) {
+            if (installationInfo.binDir !== "") {
               success += `\nThe binary direcotry is ${installationInfo.binDir}`
             }
             toolsSucceeded.push(success)