Skip to content

Commit 4aa1b06

Browse files
committed
ci: smoke test node 12 and 16 separately
1 parent 39419e1 commit 4aa1b06

File tree

1 file changed

+18
-8
lines changed

1 file changed

+18
-8
lines changed

.github/workflows/CI.yml

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,7 @@ jobs:
2323
- ubuntu-20.04
2424
- macos-12
2525
- macos-11
26-
cache_reset_counter:
27-
- 0
2826
node:
29-
- 12
30-
- 16
3127
- 18
3228
pnpm:
3329
- 8
@@ -64,10 +60,26 @@ jobs:
6460
# uses: mxschmitt/action-tmate@v3
6561

6662
- name: Test
67-
if: "${{ !contains(github.event.head_commit.message, '[skip test]') && contains(matrix.node, '18') }}"
63+
if: "${{ !contains(github.event.head_commit.message, '[skip test]') }}"
6864
run: |
6965
pnpm run test
7066
67+
- name: Setup Node 12
68+
uses: actions/setup-node@v3
69+
with:
70+
node-version: 12
71+
- name: Smoke Test Node 12
72+
run: |
73+
node ./dist/node12/setup-cpp.js --help
74+
75+
- name: Setup Node 16
76+
uses: actions/setup-node@v3
77+
with:
78+
node-version: 16
79+
- name: Smoke Test Node 16
80+
run: |
81+
node ./dist/node16/setup-cpp.js --help
82+
7183
# Create self-contained executable that bundles Nodejs
7284
- name: Create Executable
7385
if: "${{ contains(matrix.os, 'windows-2022') || contains(matrix.os, 'ubuntu-22.04') || contains(matrix.os, 'macos-12') }}"
@@ -127,8 +139,6 @@ jobs:
127139
- "ubuntu_20.04_node.dockerfile"
128140
- "ubuntu_node_legacy.dockerfile"
129141
- "ubuntu_node.dockerfile"
130-
cache_reset_counter:
131-
- 0
132142
steps:
133143
- uses: actions/checkout@v3
134144
with:
@@ -140,7 +150,7 @@ jobs:
140150
path: |
141151
~/.pnpm-store
142152
D:\.pnpm-store
143-
key: "setupcpp-docker-cache-OS:${{ matrix.os }}-node:${{ matrix.node }}-pnpm:${{ matrix.pnpm }}-${{ hashFiles('./.npmrc') }}-deps:${{ hashFiles('./package.json') }}-${{ matrix.cache_reset_counter }}"
153+
key: "setupcpp-docker-cache-OS:${{ matrix.os }}-${{ hashFiles('./.npmrc') }}-deps:${{ hashFiles('./package.json') }}"
144154
restore-keys: |
145155
"setupcpp-docker-cache-OS:${{ matrix.os }}"
146156

0 commit comments

Comments
 (0)