Skip to content

Commit 313d3ec

Browse files
committed
fix: do not pass args to msvc choco
1 parent a381fc0 commit 313d3ec

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

src/msvc/msvc.ts

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,29 +23,19 @@ export async function setupMSVC(
2323
try {
2424
if (version === "2015") {
2525
toolset = "14.0.25420.1"
26-
await setupChocoPack("visualcpp-build-tools", toolset, [
27-
"--ignore-dependencies",
28-
"--params",
29-
"'/IncludeRequired'",
30-
])
26+
await setupChocoPack("visualcpp-build-tools", toolset, [])
3127

3228
VCTargetsPath = "C:/Program Files (x86)/MSBuild/Microsoft.Cpp/v4.0/v140"
3329
if (existsSync(VCTargetsPath)) {
3430
exportVariable("VCTargetsPath", VCTargetsPath)
3531
}
3632
} else if (version === "2017") {
3733
toolset = "14.16"
38-
await setupChocoPack("visualstudio2017buildtools", "15.9.41.0", [
39-
"--package-parameters",
40-
"'--add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive'",
41-
])
34+
await setupChocoPack("visualstudio2017buildtools", "15.9.41.0", [])
4235
// VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.16" // TODO verify path
4336
} else if (version === "2019") {
4437
toolset = "14.29"
45-
await setupChocoPack("visualstudio2019buildtools", "16.11.7.0", [
46-
"--package-parameters",
47-
"'--add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive'",
48-
])
38+
await setupChocoPack("visualstudio2019buildtools", "16.11.7.0", [])
4939
// VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133"
5040
}
5141
} catch (e) {

0 commit comments

Comments
 (0)