fix: make sure the tool has a default version before using it

Author: aminya

dist/node12/setup-cpp.js

@@ -15,7 +15,7 @@ function getLLVMDefault() {
   }
 }
 
-export const DefaultVersions: Record<string, string> = {
+export const DefaultVersions: Record<string, string | undefined> = {
   llvm: getLLVMDefault(), // https://github.com/llvm/llvm-project/releases
   clangtidy: getLLVMDefault(),
   clangformat: getLLVMDefault(),

dist/node12/setup-cpp.js.map

@@ -5,11 +5,11 @@ import { DefaultLinuxVersion, DefaultVersions } from "./default_versions"
 /** Get the default version if passed true or undefined, otherwise return the version itself */
 export function getVersion(name: string, version: string | undefined, osVersion: number[] | null = null) {
   if (isDefault(version, name)) {
-    if (process.platform === "linux" && osVersion !== null && name in DefaultLinuxVersion) {
+    if (process.platform === "linux" && osVersion !== null) {
       return getDefaultLinuxVersion(name, osVersion)
     }
     // anything else
-    return DefaultVersions[name]
+    return DefaultVersions[name]! // checked by isDefault
   } else {
     return version ?? ""
   }
@@ -28,8 +28,8 @@ function getDefaultLinuxVersion(name: string, osVersion: number[]) {
   return satisfyingVersion === undefined ? "" : DefaultLinuxVersion[name][satisfyingVersion]
 }
 
-export function isDefault(version: string | undefined, name: string) {
-  return version === "true" || (version === undefined && name in DefaultVersions)
+function isDefault(version: string | undefined, name: string) {
+  return (version === "true" || version === undefined) && name in DefaultLinuxVersion
 }
 
 /**