fix: unset Path, TMP, and TEMP before MSVC installations

Author: aminya

dist/setup_cpp.js

@@ -22,7 +22,6 @@ export async function setupMSVC(
 
   let toolset: string | undefined
   let VCTargetsPath: string | undefined
-  // TODO enable this code path once its bugs are fixed
   // https://github.com/aminya/setup-cpp/issues/1
   try {
     if (version === "14.0") {
@@ -41,13 +40,7 @@ export async function setupMSVC(
       error(`The given MSVC versions ${versionGiven} is not supported yet.`)
     }
   } catch (e) {
-    if (
-      !(e as string | Error)
-        .toString()
-        .includes("Item has already been added. Key in dictionary: 'Path'  Key being added: 'PATH'")
-    ) {
-      error(e as string | Error)
-    }
+    error(e as string | Error)
   }
   // run vcvarsall.bat environment variables
   setupVCVarsall(version, VCTargetsPath, arch, toolset, sdk, uwp, spectre)

dist/setup_cpp.js.map

@@ -14,10 +14,18 @@ export async function setupChocoPack(name: string, version?: string, args: strin
     hasChoco = true
   }
 
+  // https://github.com/jberezanski/ChocolateyPackages/issues/97#issuecomment-986825694
+  const PATH = process.env.PATH
+  const env = { ...process.env }
+  delete env.TMP
+  delete env.TEMP
+  delete env.Path
+  env.PATH = PATH
+
   if (version !== undefined && version !== "") {
-    execa.sync("choco", ["install", "-y", name, `--version=${version}`, ...args])
+    execa.sync("choco", ["install", "-y", name, `--version=${version}`, ...args], { env, extendEnv: false })
   } else {
-    execa.sync("choco", ["install", "-y", name, ...args])
+    execa.sync("choco", ["install", "-y", name, ...args], { env, extendEnv: false })
   }
 
   const binDir = "C:/ProgramData/Chocolatey/bin/"