Skip to content

Commit 0e9ce85

Browse files
committed
fix: add the missing macos/windows versions
1 parent 79523d5 commit 0e9ce85

File tree

6 files changed

+16
-14
lines changed

6 files changed

+16
-14
lines changed

dist/node12/setup_cpp.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/node12/setup_cpp.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/node16/setup_cpp.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/node16/setup_cpp.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/llvm/llvm_url.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,15 @@ export const VERSIONS: Set<string> = getVersions([
5959
"15.0.2",
6060
"15.0.3",
6161
"15.0.4",
62-
// missing binaries for Windows
63-
// "15.0.5",
64-
// "15.0.6",
62+
"15.0.5",
63+
"15.0.6",
6564
])
6665

66+
/** The LLVM versions that were never released for the Windows platform. */
67+
const WIN32_MISSING: Set<string> = new Set(["10.0.1", "15.0.5", "15.0.6"])
68+
6769
/** The LLVM versions that were never released for the Darwin platform. */
68-
const DARWIN_MISSING: Set<string> = new Set([
70+
const DARWIN_MISSING = new Set([
6971
"3.5.1",
7072
"3.6.1",
7173
"3.6.2",
@@ -79,6 +81,9 @@ const DARWIN_MISSING: Set<string> = new Set([
7981
"11.0.1",
8082
"11.1.0",
8183
"12.0.1",
84+
"15.0.4",
85+
"15.0.5",
86+
"15.0.6",
8287
])
8388

8489
/**
@@ -217,9 +222,6 @@ export function getLinuxUrl(versionGiven: string): string {
217222
}
218223
}
219224

220-
/** The LLVM versions that were never released for the Windows platform. */
221-
const WIN32_MISSING: Set<string> = new Set(["10.0.1"])
222-
223225
/** Gets an LLVM download URL for the Windows platform. */
224226
async function getWin32Url(version: string): Promise<string | null> {
225227
if (WIN32_MISSING.has(version)) {

src/versions/default_versions.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import { isArch } from "../utils/env/isArch"
44
// the directly downloaded tools require a given version ("" doesn't work).
55

66
export const DefaultVersions: Record<string, string> = {
7-
llvm: "15.0.4", // https://github.com/llvm/llvm-project/releases
8-
clangtidy: "15.0.4",
9-
clangformat: "15.0.4",
7+
llvm: process.platform === "darwin" ? "15.0.3" : "15.0.4", // https://github.com/llvm/llvm-project/releases
8+
clangtidy: process.platform === "darwin" ? "15.0.3" : "15.0.4",
9+
clangformat: process.platform === "darwin" ? "15.0.3" : "15.0.4",
1010
ninja: "1.11.1", // https://github.com/ninja-build/ninja/releases
1111
cmake: "3.25.0", // https://github.com/Kitware/CMake/releases
1212
gcovr: "5.2", // https://pypi.org/project/gcovr/

0 commit comments

Comments
 (0)