fix: select the default llvm version based on ubuntu version

Author: aminya

dist/setup_cpp.js

@@ -38,12 +38,14 @@
     "@actions/io": "^1.1.2",
     "@actions/tool-cache": "^1.7.2",
     "execa": "^5.1.1",
+    "make-synchronous": "^1.0.0",
     "mri": "^1.2.0",
     "msvc-dev-cmd": "github:aminya/msvc-dev-cmd#9f672c1",
     "numerous": "1.0.3",
     "semver": "7.3.7",
     "setup-python": "github:actions/setup-python#v3.1.2",
     "time-delta": "github:aminya/time-delta#69d91a41cef28e569be9a2991129f5f7d1f0d00e",
+    "ubuntu-version": "^2.0.0",
     "untildify": "^4.0.0",
     "which": "^2.0.2"
   },

dist/setup_cpp.js.map

@@ -1,3 +1,6 @@
+import { warning } from "./utils/io/io"
+import { ubuntuVersion } from "./utils/env/ubuntu_version"
+
 const DefaultVersions: Record<string, string> = {
   llvm: "13.0.0", // https://github.com/llvm/llvm-project/releases
   clangtidy: "13.0.0",
@@ -14,6 +17,8 @@ const DefaultVersions: Record<string, string> = {
   gcc: process.platform === "win32" ? "11.2.0.07112021" : "11", // https://community.chocolatey.org/packages/mingw#versionhistory and // https://packages.ubuntu.com/search?suite=all&arch=any&searchon=names&keywords=gcc
 }
 
+let ubuntuVersionCached: number[] | null = null
+
 /** Get the default version if passed true or undefined, otherwise return the version itself */
 export function getVersion(name: string, version: string | undefined) {
   if (version === "true" || (version === undefined && name in DefaultVersions)) {
@@ -22,3 +27,24 @@ export function getVersion(name: string, version: string | undefined) {
     return version ?? ""
   }
 }
+
+export function defaultLLVMVersion(name: string) {
+  if (["llvm", "clangtidy", "clangformat"].includes(name)) {
+    if (process.platform === "linux") {
+      try {
+        // get the version if not already done
+        ubuntuVersionCached = ubuntuVersionCached ?? ubuntuVersion()
+      } catch (err) {
+        warning((err as Error).toString())
+        return DefaultVersions[name]
+      }
+      // choose the default version for llvm based on ubuntu
+      if (ubuntuVersionCached !== null) {
+        if ([20, 18, 16].includes(ubuntuVersionCached[0]) && ubuntuVersionCached[1] === 4) {
+          return `-13.0.0-x86_64-linux-gnu-ubuntu-${ubuntuVersionCached[0]}.0${ubuntuVersionCached[1]}`
+        }
+      }
+    }
+  }
+  return DefaultVersions[name]
+}

package.json

@@ -124,6 +124,7 @@ const UBUNTU_RC: Map<string, string> = new Map()
  *
  * https://github.com/llvm/llvm-project/releases/tag/llvmorg-14.0.1 or https://releases.llvm.org/14.0.1
  */
+// TODO change based on ubuntu version
 const UBUNTU_SUFFIX_MAP: { [key: string]: string } = {
   "3.5.0": "-ubuntu-14.04",
   "3.5.1": "",

pnpm-lock.yaml

@@ -0,0 +1,16 @@
+import { getUbuntuVersion } from "ubuntu-version"
+import makeSynchronous from "make-synchronous"
+
+export function ubuntuVersion(): number[] | null {
+  if (process.platform === "linux") {
+    const versionSplitted = makeSynchronous(getUbuntuVersion)()
+
+    if (versionSplitted.length === 0) {
+      throw new Error("Failed to get the ubuntu major version.")
+    }
+
+    return versionSplitted
+  } else {
+    return null
+  }
+}