rename variable

Author: Forgind

src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs

@@ -39,7 +39,7 @@ internal class NuGetPackageDownloader : INuGetPackageDownloader
         private readonly IFirstPartyNuGetPackageSigningVerifier _firstPartyNuGetPackageSigningVerifier;
         private bool _validationMessagesDisplayed = false;
         private IDictionary<PackageSource, SourceRepository> _sourceRepositories;
-        private readonly bool _isNuGetTool;
+        private readonly bool _shouldUsePackageSourceMapping;
 
         private bool _verifySignatures;
         private VerbosityOptions _verbosityOptions;
@@ -53,7 +53,7 @@ public NuGetPackageDownloader(
             RestoreActionConfig restoreActionConfig = null,
             Func<IEnumerable<Task>> timer = null,
             bool verifySignatures = false,
-            bool isNuGetTool = false,
+            bool shouldUsePackageSourceMapping = false,
             VerbosityOptions verbosityOptions = VerbosityOptions.normal)
         {
             _packageInstallDir = packageInstallDir;
@@ -76,7 +76,7 @@ public NuGetPackageDownloader(
 
             DefaultCredentialServiceUtility.SetupDefaultCredentialService(new NuGetConsoleLogger(),
                 !_restoreActionConfig.Interactive);
-            _isNuGetTool = isNuGetTool;
+            _shouldUsePackageSourceMapping = shouldUsePackageSourceMapping;
             _verbosityOptions = verbosityOptions;
         }
 
@@ -330,7 +330,7 @@ private IEnumerable<PackageSource> LoadNuGetSources(PackageId packageId, Package
             packageSourceMapping ??= PackageSourceMapping.GetPackageSourceMapping(settings);
 
             // filter package patterns if enabled            
-            if (_isNuGetTool && packageSourceMapping?.IsEnabled == true)
+            if (_shouldUsePackageSourceMapping && packageSourceMapping?.IsEnabled == true)
             {
                 IReadOnlyList<string> sources = packageSourceMapping.GetConfiguredPackageSources(packageId.ToString());
 

src/Cli/dotnet/ToolPackage/ToolPackageDownloader.cs

@@ -100,7 +100,7 @@ public IToolPackage InstallPackage(PackageLocation packageLocation, PackageId pa
 
                     var toolDownloadDir = isGlobalTool ? _globalToolStageDir : _localToolDownloadDir;
                     var assetFileDirectory = isGlobalTool ? _globalToolStageDir : _localToolAssetDir;
-                    var nugetPackageDownloader = new NuGetPackageDownloader.NuGetPackageDownloader(toolDownloadDir, verboseLogger: nugetLogger, isNuGetTool: true, verbosityOptions: verbosity);
+                    var nugetPackageDownloader = new NuGetPackageDownloader.NuGetPackageDownloader(toolDownloadDir, verboseLogger: nugetLogger, shouldUsePackageSourceMapping: true, verbosityOptions: verbosity);
 
                     var packageSourceLocation = new PackageSourceLocation(packageLocation.NugetConfig, packageLocation.RootConfigDirectory, null, packageLocation.AdditionalFeeds);
 
@@ -401,7 +401,7 @@ public NuGetVersion GetNuGetVersion(
             var nugetPackageDownloader = new NuGetPackageDownloader.NuGetPackageDownloader(
                 packageInstallDir: isGlobalTool ? _globalToolStageDir : _localToolDownloadDir,
                 verboseLogger: nugetLogger,
-                isNuGetTool: true,
+                shouldUsePackageSourceMapping: true,
                 verbosityOptions: verbosity);
 
             var packageSourceLocation = new PackageSourceLocation(

src/Cli/dotnet/commands/dotnet-workload/WorkloadCommandBase.cs

@@ -117,7 +117,7 @@ public WorkloadCommandBase(
                 Reporter,
                 restoreActionConfig: RestoreActionConfiguration,
                 verifySignatures: VerifySignatures,
-                isNuGetTool: true);
+                shouldUsePackageSourceMapping: true);
         }
 
         /// <summary>

test/Microsoft.DotNet.PackageInstall.Tests/NuGetPackageInstallerTests.cs

@@ -38,7 +38,7 @@ public NuGetPackageInstallerTests(ITestOutputHelper log) : base(log)
                     restoreActionConfig: new RestoreActionConfig(NoCache: true), timer: () => ExponentialRetry.Timer(ExponentialRetry.TestingIntervals));
             _toolInstaller =
                 new NuGetPackageDownloader(_tempDirectory, null, new MockFirstPartyNuGetPackageSigningVerifier(), _logger,
-                    restoreActionConfig: new RestoreActionConfig(NoCache: true), timer: () => ExponentialRetry.Timer(ExponentialRetry.TestingIntervals), isNuGetTool: true);
+                    restoreActionConfig: new RestoreActionConfig(NoCache: true), timer: () => ExponentialRetry.Timer(ExponentialRetry.TestingIntervals), shouldUsePackageSourceMapping: true);
         }
 
         [Fact]