Skip to content

Commit 0d99373

Browse files
authored
Stop generating precomputed rar cache (dotnet#42385)
1 parent cd1ce19 commit 0d99373

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/Installer/redist-installer/targets/GenerateLayout.targets

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,8 @@
590590
Importance="High" />
591591
</Target>
592592

593+
<!-- This target no longer runs by default. The ResolveAssemblyReference task is substantially faster if it has a cache, so the idea was to precompute a cache for commonly resolved (SDK) assemblies,
594+
but the expected performance win did not materialize. This target can take multiple minutes to run with every build, so disabling it until/unless we find good value for it. -->
593595
<Target Name="GeneratePrecomputedRarCache" DependsOnTargets="LayoutTemplates;LayoutManifests;LayoutBundledTools">
594596
<ItemGroup>
595597
<AssembliesToResolve Include="$(RedistLayoutPath)\**\*.dll" Exclude="$(RedistLayoutPath)\**\native\**\*.dll" />
@@ -621,7 +623,6 @@
621623
RetargetTools;
622624
CrossgenLayout;
623625
LayoutAppHostTemplate;
624-
GeneratePrecomputedRarCache;
625626
ReplaceBundledRuntimePackFilesWithSymbolicLinks"
626627
BeforeTargets="AfterBuild" />
627628

0 commit comments

Comments
 (0)