Skip to content

Commit 22f08a0

Browse files
authored
Merge pull request #197 from amadeus4dev/fix-traveler-model
Update Traveler resource model
2 parents 0fb2ca5 + b5f91d7 commit 22f08a0

File tree

4 files changed

+48
-129
lines changed

4 files changed

+48
-129
lines changed

src/main/java/com/amadeus/booking/FlightOrders.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
import com.amadeus.exceptions.ResponseException;
66
import com.amadeus.resources.FlightOfferSearch;
77
import com.amadeus.resources.FlightOrder;
8+
import com.amadeus.resources.FlightOrder.Traveler;
89
import com.amadeus.resources.FlightPrice;
910
import com.amadeus.resources.Resource;
10-
import com.amadeus.resources.Traveler;
1111
import com.google.gson.Gson;
1212
import com.google.gson.GsonBuilder;
1313
import com.google.gson.JsonArray;
Lines changed: 36 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
package com.amadeus.resources;
22

3-
import java.util.Date;
3+
import lombok.AllArgsConstructor;
44
import lombok.Getter;
5+
import lombok.NoArgsConstructor;
6+
import lombok.Setter;
57
import lombok.ToString;
68

79
/**
@@ -30,56 +32,56 @@ protected AssociatedRecord() {
3032
private @Getter String flightOfferId;
3133
}
3234

35+
@AllArgsConstructor
36+
@NoArgsConstructor
3337
@ToString
34-
public class Traveler {
35-
protected Traveler() {
36-
}
38+
public static class Traveler {
3739

38-
private @Getter String id;
39-
private @Getter Date dateOfBirth;
40-
private @Getter Name name;
41-
private @Getter Contact contact;
42-
private @Getter Document[] documents;
40+
private @Getter @Setter String id;
41+
private @Getter @Setter String dateOfBirth;
42+
private @Getter @Setter Name name;
43+
private @Getter @Setter Contact contact;
44+
private @Getter @Setter Document[] documents;
4345
}
4446

47+
@AllArgsConstructor
48+
@NoArgsConstructor
4549
@ToString
46-
public class Name {
47-
protected Name() {
48-
}
50+
public static class Name {
4951

50-
private @Getter String firstName;
51-
private @Getter String lastName;
52+
private @Getter @Setter String firstName;
53+
private @Getter @Setter String lastName;
5254
}
5355

56+
@AllArgsConstructor
57+
@NoArgsConstructor
5458
@ToString
55-
public class Contact {
56-
protected Contact() {
57-
}
59+
public static class Contact {
5860

59-
private @Getter Phone[] phones;
61+
private @Getter @Setter Phone[] phones;
62+
private @Getter @Setter String deviceType;
6063
}
6164

65+
@AllArgsConstructor
66+
@NoArgsConstructor
6267
@ToString
63-
public class Document {
64-
protected Document() {
65-
}
66-
67-
private @Getter String documentType;
68-
private @Getter String number;
69-
private @Getter Date expiryDate;
70-
private @Getter String issuanceCountry;
71-
private @Getter String nationality;
72-
private @Getter boolean holder;
68+
public static class Document {
69+
70+
private @Getter @Setter String documentType;
71+
private @Getter @Setter String number;
72+
public @Getter @Setter String expiryDate;
73+
private @Getter @Setter String issuanceCountry;
74+
private @Getter @Setter String nationality;
75+
private @Getter @Setter boolean holder;
7376
}
7477

78+
@AllArgsConstructor
79+
@NoArgsConstructor
7580
@ToString
76-
public class Phone {
81+
public static class Phone {
7782

78-
protected Phone() {
79-
}
80-
81-
private @Getter String countryCallingCode;
82-
private @Getter String number;
83+
private @Getter @Setter String countryCallingCode;
84+
private @Getter @Setter String number;
8385
}
8486

8587
}

src/main/java/com/amadeus/resources/Traveler.java

Lines changed: 0 additions & 86 deletions
This file was deleted.

src/test/java/com/amadeus/booking/FlightOrdersIT.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,12 @@
99
import com.amadeus.exceptions.ResponseException;
1010
import com.amadeus.resources.FlightOfferSearch;
1111
import com.amadeus.resources.FlightOrder;
12+
import com.amadeus.resources.FlightOrder.Contact;
13+
import com.amadeus.resources.FlightOrder.Document;
14+
import com.amadeus.resources.FlightOrder.Name;
15+
import com.amadeus.resources.FlightOrder.Phone;
16+
import com.amadeus.resources.FlightOrder.Traveler;
1217
import com.amadeus.resources.FlightPrice;
13-
import com.amadeus.resources.Traveler;
1418
import com.github.tomakehurst.wiremock.WireMockServer;
1519
import com.google.gson.JsonObject;
1620
import com.google.gson.JsonParser;
@@ -103,20 +107,19 @@ private Traveler[] getTravelerData() {
103107

104108
traveler.setId("1");
105109
traveler.setDateOfBirth("2000-04-14");
106-
traveler.setName(traveler.new Name("JORGE", "GONZALES"));
110+
traveler.setName(new Name("JORGE", "GONZALES"));
107111

108-
Traveler.Phone[] phone = new Traveler.Phone[1];
109-
phone[0] = traveler.new Phone();
112+
Phone[] phone = new Phone[1];
113+
phone[0] = new Phone();
110114
phone[0].setCountryCallingCode("33");
111115
phone[0].setNumber("675426222");
112-
phone[0].setDeviceType("MOBILE");
113116

114-
Traveler.Contact contact = traveler.new Contact();
117+
Contact contact = new Contact();
115118
contact.setPhones(phone);
116119
traveler.setContact(contact);
117120

118-
Traveler.Document[] document = new Traveler.Document[1];
119-
document[0] = traveler.new Document();
121+
Document[] document = new Document[1];
122+
document[0] = new Document();
120123
document[0].setDocumentType("PASSPORT");
121124
document[0].setNumber("480080076");
122125
document[0].setExpiryDate("2022-10-11");

0 commit comments

Comments
 (0)