why are we silenting this error ?

[rohansx]

In the provided code, the error from the DumpSchema function is explicitly silenced in the following block:

dbmate/pkg/dbmate/db.go

Line 418 in 48032cb

_ = db.DumpSchema()

// automatically update schema file, silence errors
if db.AutoDumpSchema {
    _ = db.DumpSchema()
}

This means that if DumpSchema fails, the error is ignored, and the program continues execution without notifying the user. While this might seem convenient in some cases, it can lead to significant issues.
Specifically, in my case, the error indicating that PostgreSQL (pg_dump) was not installed or not in the PATH was suppressed, making it harder to debug the problem.

@amacneil

[amacneil]

The thinking was that not everyone has pg_dump installed, and that shouldn't be a blocker.

If you run dbmate dump it will not silence the error, so you can figure out what is going on.

[rohansx]

got it, thanks!!