Added empty spans for blank elements

Author: fabn

lib/active_admin/globalize/attributes_table_extension.rb

@@ -88,10 +88,19 @@ def field_translations(field, tag, initial_locale)
           css_classes = ['field-translation', "locale-#{translation.locale}"]
           # Initially only element for selected locale is visible
           css_classes.push 'hidden' unless translation.locale == initial_locale.to_sym
-          # build span with translation
-          content_tag(tag, class: css_classes) do
-            # If block given call it with translation model, else return raw value of field
-            block_given? ? yield(translation) : translation.send(field)
+          # Build content for cell or div
+          content = block_given? ? yield(translation) : translation.send(field)
+          # return element
+          if tag == :span # inline element
+            # attach class to span if inline
+            css_classes.push(:empty) if content.blank?
+            content_tag(tag, content.presence || 'Empty', class: css_classes)
+          else
+            # block content
+            content_tag(tag, class: css_classes) do
+              # Return content or empty span
+              content.presence || content_tag(:span, 'Empty', class: 'empty')
+            end
           end
         end.join(' ').html_safe
       end

spec/dummy/app/models/article.rb

@@ -2,9 +2,6 @@ class Article < ActiveRecord::Base
   attr_accessible :title, :body, :translations_attributes
 
   # Translated fields with globalize and for active admin
-  active_admin_translates :title, :body do
-    # Here I'm inside the Person::Translation which is an AR class
-    validates_presence_of :title, :body
-  end
+  active_admin_translates :title, :body
 
 end

spec/features/article_composing_spec.rb

@@ -77,6 +77,26 @@
 
     end
 
+    scenario 'Viewing empty translations' do
+      # create empty translations for it
+      I18n.with_locale(:de) { article.update_attributes! title: '', body: '' }
+      # Reload article page
+      visit admin_article_path(article)
+
+      # First row shows default locale with label title
+      within first_table_row do
+        flag_link(:de).click # change shown translation
+        page.should have_css 'span.field-translation.empty', text: 'EMPTY'
+      end
+
+      # Third table has a block translation element
+      within third_table_row do
+        tab_link(:de).click # change shown translation
+        page.should have_css 'div.field-translation span.empty', text: 'EMPTY'
+      end
+
+    end
+
   end
 
 end