:habit selector not being accepted

[landermkerbey]

OS/platform

Arch Linux

Emacs version and provenance

GNU Emacs 30.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.48, cairo version 1.18.2)
Acquired and installed via Pacman

Emacs command

emacsclient -c -a ""

Org version and provenance

Org mode version 9.8-pre (release_9.7.22-251-gff33d9)

org-super-agenda package version and provenance

1.4-pre, acquired via straight.el and configured with straight-use-package aliased to use-package

Actions taken

I have defined a block in my agenda thusly:

(alltodo "" ((org-agenda-overriding-header "")
	     (org-super-agenda-groups
	      '((:discard
		 (:tag "writing"))
		(:name "Priority"
		       :tag "priority"
		       :order 0)
		(:name "Overdue"
		       :deadline past
		       :order 1)
		(:name "Pending"
		       :scheduled past
		       :order 2)
		(:name "Today"
		       :scheduled today
		       :deadline today
		       :order 3)
		(:discard
		 (:anything t))))))

This is causing my habits to appear in the 'Today' section, which is redundant as the preceding block already separates those out into a time-grid display. So, to filter the habits out, I make the following modification:

(alltodo "" ((org-agenda-overriding-header "")
	     (org-super-agenda-groups
	      '((:discard (:and 
                  :habit t
		 (:tag "writing"))
		(:name "Priority"
		       :tag "priority"
		       :order 0)
		(:name "Overdue"
		       :deadline past
		       :order 1)
		(:name "Pending"
		       :scheduled past
		       :order 2)
		(:name "Today"
		       :scheduled today
		       :deadline today
		       :order 3)
		(:discard
		 (:anything t))))))

Observed results

I get this error:

org-super-agenda--get-selector-fn: Invalid org-super-agenda-groups selector: (:habit t :tag writing)

It is at this point that I remember we're dealing with logical "and" here (duh!) so I try a few different contortions to get this to work. These are irrelevant, because I begin to suspect that the issue is with the :habit selector specifically. I simplify:

(alltodo "" ((org-agenda-overriding-header "")
	     (org-super-agenda-groups
	      '((:discard  
                 (:habit t))
		(:name "Priority"
		       :tag "priority"
		       :order 0)
		(:name "Overdue"
		       :deadline past
		       :order 1)
		(:name "Pending"
		       :scheduled past
		       :order 2)
		(:name "Today"
		       :scheduled today
		       :deadline today
		       :order 3)
		(:discard
		 (:anything t))))))

And my suspicion seems to be confirmed, because I still see:

org-super-agenda--get-selector-fn: Invalid org-super-agenda-groups selector: (:habit t)

Now, I go check my copy of org-super-agenda.el and check out that get-selector-fn. If I check the value of the variable org-super-agenda-group-types, I see an entry that seems to indicate :habit should be supported:

:habit
org-super-agenda--group-habit

This is as far as I've gotten poking at the issue.

Expected results

I expect the :habit selector to be recognized and for this to filter out my habit items.

Backtrace

The error specified above is the extent of the messaging even with `toggle-debug-on-error` enabled.

Etc.

No response

[alphapapa]

Hello,

I've tried but I can't reproduce the problems you're reporting. You filled out the template well, but it's still not a completely reproducible example, because you provided just part of the agenda definition (the alltodo block). Ideally it would be a self-contained, evaluatable form, like:

(let ((org-agenda-custom-commands
       '(("a" "foo"
          ((alltodo "" ((org-agenda-overriding-header "")
                        (org-super-agenda-groups
                         '((:discard (:and
                                      (:habit t :tag "writing")))
                           (:name "Priority"
                                  :tag "priority"
                                  :order 0)
                           (:name "Overdue"
                                  :deadline past
                                  :order 1)
                           (:name "Pending"
                                  :scheduled past
                                  :order 2)
                           (:name "Today"
                                  :scheduled today
                                  :deadline today
                                  :order 3)
                           (:discard
                            (:anything t))))))))))
      (org-agenda-files '("/home/me/src/emacs/org-super-agenda/test/test.org")))
  (org-agenda nil "a"))

Having said that, the errors you shared seem to indicate that the selector list is invalid, and that seems to be the case, i.e. this:

(:discard
 (:and
  :habit t
  (:tag "writing")))

Is not valid, whereas this:

(:discard
 (:and
  (:habit t :tag "writing")))

Is valid.

I realize that it can be confusing, this bespoke, plist-based expression format. In org-ql I eschewed that in favor of actual Lisp expressions, and someday I intend to finish the integration of org-ql with taxy so that grouping and filtering will be more like actual Lisp. In the meantime, nuances like this sometimes require careful attention to detail, and sometimes some experimentation. You can see some examples here, which should help: https://github.com/alphapapa/org-super-agenda/blob/master/examples.org

AFAICT there is no bug here, even though you're on a pre-release version of Org installed with Straight. But it's also hard to rule that out completely. And, not to denigrate Straight, but over the years, I have had numerous problem reports from users due to the way Straight installs dependencies at various versions, so I can't really recommend using it unless you're willing to deal with the occasional issue and having to manually override a version here or there.

If the valid form I showed above doesn't fix the problem, the next step I would recommend is to use https://github.com/alphapapa/with-emacs.sh to install Org and org-super-agenda into a clean configuration and make a minimal working example that reproduces the problem, with a test data file--and I do mean minimal, i.e. as few selectors and test entries as necessary to demonstrate the problem.