Fix set for and reactivity (#315)

Fix sets with mapJoin (#199). Sets were just never supported in mapJoin
even though `For` said they were.

Also fixes an issue where immediately recursive effects wouldn't run.

Author: bterlson

.chronus/changes/fix-set-for-and-reactivity-2025-9-7-16-27-52.md

@@ -0,0 +1,7 @@
+---
+changeKind: fix
+packages:
+  - "@alloy-js/core"
+---
+
+Fix For component and mapJoin with sets.

.chronus/changes/fix-set-for-and-reactivity-2025-9-7-16-28-18.md

@@ -0,0 +1,7 @@
+---
+changeKind: fix
+packages:
+  - "@alloy-js/core"
+---
+
+Fix immediately recursive reactives.

.chronus/changes/fix-set-for-and-reactivity-2025-9-8-0-57-49.md

@@ -0,0 +1,7 @@
+---
+changeKind: fix
+packages:
+  - "@alloy-js/core"
+---
+
+toRefkey is now untracked, preventing unintended effect triggering.

.chronus/changes/fix-set-for-and-reactivity-2025-9-8-0-59-9.md

@@ -0,0 +1,7 @@
+---
+changeKind: fix
+packages:
+  - "@alloy-js/go"
+---
+
+Moved type parameters to actual symbols in a member space of named type symbols. Added `receiverSymbol` to function symbols.

packages/core/src/reactivity.ts

@@ -156,7 +156,10 @@ export function effect<T>(fn: (prev?: T) => T, current?: T) {
       }
     },
     {
-      scheduler: scheduler(() => runner),
+      // allow recursive effects with 32, 1 and 4 are default flags
+      // @ts-expect-error flags is a vue internal thing
+      flags: 1 | 4 | 32,
+      scheduler: scheduler(),
       onTrack(event) {
         trace(TracePhase.effect.track, () => {
           return `tracking ${event.target}, ${String(event.key)}`;

packages/core/src/refkey.ts

@@ -1,4 +1,5 @@
 import { markRaw } from "@vue/reactivity";
+import { untrack } from "./reactivity.js";
 
 const objectIds = new WeakMap<WeakKey, string>();
 let objId = 0;
@@ -21,7 +22,7 @@ export type RefkeyableObject = {
 };
 
 export function toRefkey(refkey: Refkeyable) {
-  return refkey[REFKEYABLE]();
+  return untrack(() => refkey[REFKEYABLE]());
 }
 
 export type Refkeyable = RefkeyableObject | Refkey;

packages/core/src/render.ts

@@ -481,6 +481,7 @@ function appendChild(node: RenderedTextTree, rawChild: Child) {
           throw new Error("Unknown intrinsic element");
       }
     } else if (isComponentCreator(child)) {
+      // todo: remove this effect (only needed for context, not needed for anything else)
       effect(() => {
         trace(
           TracePhase.render.appendChild,
@@ -581,6 +582,8 @@ function debugPrintChild(child: Children): string {
     return `<${child.name}>`;
   } else if (isRenderableObject(child)) {
     return `CustomChildElement(${JSON.stringify(child)})`;
+  } else if (isRefkeyable(child)) {
+    return `refkey`;
   } else {
     return JSON.stringify(child);
   }

packages/core/src/scheduler.ts

@@ -1,24 +1,25 @@
-import { ReactiveEffectRunner } from "@vue/reactivity";
+import { ReactiveEffect } from "@vue/reactivity";
 
 export interface QueueJob {
-  (): any;
+  run(): void;
 }
 const immediateQueue = new Set<QueueJob>();
 const queue = new Set<QueueJob>();
 const pendingPromises = new Set<Promise<any>>();
 
-export function scheduler(
-  jobGetter: () => ReactiveEffectRunner,
-  immediate = false,
-) {
-  return () => {
-    queueJob(jobGetter(), immediate);
+export function scheduler(immediate = false) {
+  return function (this: ReactiveEffect) {
+    queueJob(this, immediate);
   };
 }
-export function queueJob(job: QueueJob, immediate = false) {
+export function queueJob(job: QueueJob | (() => void), immediate = false) {
   // if we have an immediate job, we don't need to queue the normal job.
   // the set is serving an important purpose here in deduping the effects we run
   // (which in effect coalesces multiple update effects together).
+  if (typeof job === "function") {
+    job = { run: job };
+  }
+
   if (immediate) {
     immediateQueue.add(job);
   } else {
@@ -41,7 +42,7 @@ export function flushJobs() {
   // First, run all synchronous jobs
   let job;
   while ((job = takeJob()) !== null) {
-    job();
+    job.run();
   }
 
   // If there are no pending promises, we're done
@@ -58,7 +59,7 @@ export async function flushJobsAsync() {
     // First, run all synchronous jobs
     let job;
     while ((job = takeJob()) !== null) {
-      job();
+      job.run();
     }
 
     // If there are no pending promises, we're done

packages/core/src/symbols/output-scope.ts

@@ -256,9 +256,9 @@ export abstract class OutputScope {
   }
 
   toString() {
-    const ownerSymbol = this.ownerSymbol ? ` for ${this.ownerSymbol}` : "";
-    return untrack(
-      () => `${this.constructor.name} ${this.name}[${this.id}]${ownerSymbol}`,
-    );
+    return untrack(() => {
+      const ownerSymbol = this.ownerSymbol ? ` for ${this.ownerSymbol}` : "";
+      return `${this.constructor.name} ${this.name}[${this.id}]${ownerSymbol}`;
+    });
   }
 }

packages/core/src/tracer.ts

@@ -1,4 +1,4 @@
-import { effect, ReactiveEffectRunner } from "@vue/reactivity";
+import { effect } from "@vue/reactivity";
 import { untrack } from "./reactivity.js";
 import { inspectRefkey, type Refkey } from "./refkey.js";
 import { scheduler } from "./scheduler.js";
@@ -210,7 +210,7 @@ export function traceEffect(phase: TracePhase, cb: () => string) {
   let first = true;
   const triggerIds = new Set<number>();
 
-  const runner: ReactiveEffectRunner<void> = effect(
+  effect(
     () => {
       if (first) {
         // just track what we need, don't log.
@@ -222,7 +222,7 @@ export function traceEffect(phase: TracePhase, cb: () => string) {
       triggerIds.clear();
     },
     {
-      scheduler: scheduler(() => runner, true),
+      scheduler: scheduler(true),
       onTrigger(event) {
         const id = triggerCount++;
         if (dids.has(id)) {