Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Error handling in Editor #49

@itspangler

Description

@itspangler

I am betting that these things are already under development, but I didn't see them as issues so I want to log them while I'm thinking about it.

In our post-processing workflow for making Atlascope layers, we do some error handling in Python that should probably happen on the Allmaps side. Since Viewer already listens for these errors, I am hoping it wouldn't be too complicated to implement in Editor. Here are the four main things:

  1. Listen for faulty topology. If a mask is topologically faulty (e.g., self-intersecting polygon), Editor should know and tell you. Perhaps it should notify in the "results" tab. It should probably show you where faulty topology is happening - something like changing color of that specific segment to red. The corresponding error in browser console below:

Screenshot 2024-04-05 at 4 10 17 PM

  1. Listen for duplicative/collinear points. Sometimes a point will get placed in the same x or y position and the render . It seems like this would be fairly easy to listen for in Editor, since the error gets logged in the browser console. As far as I can tell, duplicative/collinear points get logged as the same kind of error as faulty topology - is there a way to split them apart in error handling?

  2. Listen for failure to compute triangulation. Is it possible for Editor to sense when the render module will not be able to compute triangulation? It would be great if this was present before a user tried to view the map in Viewer. Error in browser below:

Screenshot 2024-04-05 at 4 10 06 PM

  1. Listen for masks with less than 3 points. it would be great to easily find masks containing less than 3 points in Editor.

One idea - what if, in the "Collection" view, thumbnails were color coded? Green for >3 points + no topology or GCP errors, red for any map with topology and/or GCP errors, and yellow for < 3 points? This would look a bit garish but I do think there should be some visual cue for catching and inviting a user to fix errors in the mask/points.

Screenshot 2024-04-05 at 4 17 09 PM

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions