Skip to content

Commit f4a8057

Browse files
committed
Fixed review comments
1 parent c9d3783 commit f4a8057

File tree

3 files changed

+3
-15
lines changed

3 files changed

+3
-15
lines changed

examples/SampleRN20/app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ var Sample2 = React.createClass({
5252
injectedJavaScript={injectScript}
5353
source={{uri: "https://google.com"}}/>
5454
<WebViewBridge
55-
ref="webviewbridge"
55+
ref="webviewbridge2"
5656
onBridgeMessage={this.onBridgeMessage}
5757
javaScriptEnabled={true}
5858
injectedJavaScript={injectScript}

webview-bridge/index.android.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,7 @@ var WebViewBridge = React.createClass({
113113
}
114114

115115
let props = {...this.props};
116-
var source = props.source || {};
117-
if(this.props.html) {
118-
source.html = this.props.html;
119-
} else if(this.props.url) {
120-
source.uri = this.props.url;
121-
}
122-
props.source = resolveAssetSource(source);
116+
props.source = resolveAssetSource(props.source);
123117

124118
var webView =
125119
<RCTWebViewBridge

webview-bridge/index.ios.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,7 @@ var WebViewBridge = React.createClass({
179179
delete props.onBridgeMessage;
180180
delete props.onShouldStartLoadWithRequest;
181181

182-
var source = props.source || {};
183-
if(this.props.html) {
184-
source.html = this.props.html;
185-
} else if(this.props.url) {
186-
source.uri = this.props.url;
187-
}
188-
props.source = resolveAssetSource(source);
182+
props.source = resolveAssetSource(props.source);
189183

190184

191185
var webView =

0 commit comments

Comments
 (0)