Merge pull request #138 from calvium/quote_in_message_causes_failure

chansuke · web-flow · commit e070577e030b · 2018-06-25T23:02:11.000+09:00
iOS: Escape singlequotes or messages containing ' will fail
diff --git a/ios/RCTWebViewBridge.m b/ios/RCTWebViewBridge.m
@@ -98,8 +98,11 @@ - (void)sendToBridge:(NSString *)message
       }
     }());
   );
+    
+  // Escape singlequotes or messages containing ' will fail
+  NSString *quotedMessage = [message stringByReplacingOccurrencesOfString:@"'" withString:@"\\'"];
 
-  NSString *command = [NSString stringWithFormat: format, message];
+  NSString *command = [NSString stringWithFormat: format, quotedMessage];
   [_webView stringByEvaluatingJavaScriptFromString:command];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,11 @@ - (void)sendToBridge:(NSString *)message`
`98`	`98`	`}`
`99`	`99`	`}());`
`100`	`100`	`);`
	`101`	`+`
	`102`	`+ // Escape singlequotes or messages containing ' will fail`
	`103`	`+ NSString *quotedMessage = [message stringByReplacingOccurrencesOfString:@"'" withString:@"\\'"];`
`101`	`104`
`102`		`- NSString *command = [NSString stringWithFormat: format, message];`
	`105`	`+ NSString *command = [NSString stringWithFormat: format, quotedMessage];`
`103`	`106`	`[_webView stringByEvaluatingJavaScriptFromString:command];`
`104`	`107`	`}`
`105`	`108`