Improved all the things!

Author: julienbourdeau

src/Console/AlgoliaCommand.php

@@ -5,16 +5,21 @@
 use AlgoliaSearch\Client;
 use Illuminate\Console\Command;
 use Illuminate\Support\Facades\File;
+use Laravel\Scout\Searchable;
 
 
 class AlgoliaCommand extends Command
 {
+    protected $path;
+
     public function __construct()
     {
         parent::__construct();
 
+        $this->path = resource_path(env('ALGOLIA_SETTINGS_FOLDER', 'algolia-settings/'));
+
         // Ensure settings directory exists
-            if (! File::exists(resource_path('settings/'))) {
+        if (! File::exists($this->path)) {
             File::makeDirectory();
         }
     }
@@ -26,4 +31,14 @@ protected function getIndex($indexName)
             config('scout.algolia.secret'))
         )->initIndex($indexName);
     }
+
+    protected function isClassSearchable($class)
+    {
+        if (!in_array(Searchable::class, class_uses($class))) {
+            $this->warn('The class [' . $class . '] does not use the [' . Searchable::class . '] trait');
+            return false;
+        }
+
+        return true;
+    }
 }

src/Console/BackupCommand.php

@@ -29,15 +29,23 @@ public function handle()
     {
         $class = $this->argument('model');
 
+        if (! $this->isClassSearchable($class)) {
+            return;
+        }
+
         $indexName = (new $class)->searchableAs();
 
         $index = $this->getIndex($indexName);
 
-        File::put(
-            resource_path('settings/'.$indexName.'json'),
+        $success = File::put(
+            $this->path.$indexName.'.json',
             json_encode($index->getSettings(), JSON_PRETTY_PRINT)
         );
 
-        $this->info('All settings for ['.$class.'] index have been backed up.');
+        if ($success) {
+            $this->info('All settings for ['.$class.'] index have been backed up.');
+        } else {
+            $this->warn('The settings could not be saved');
+        }
     }
 }

src/Console/PushCommand.php

@@ -2,6 +2,7 @@
 
 namespace Algolia\Settings\Console;
 
+use AlgoliaSearch\Json;
 use Illuminate\Support\Facades\File;
 
 class PushCommand extends AlgoliaCommand
@@ -29,15 +30,21 @@ public function handle()
     {
         $class = $this->argument('model');
 
+        if (! $this->isClassSearchable($class)) {
+            return;
+        }
+
         $indexName = (new $class)->searchableAs();
 
         $index = $this->getIndex($indexName);
 
-        $settings = json_decode(File::get(
-            resource_path('settings/'.$indexName.'json')
-        ));
+        $jsonSettings = File::get($this->path.$indexName.'.json');
+
+        if (! $jsonSettings) {
+            $this->warn("It seems that you don't have any settings to push for [$class].");
+        }
 
-        $index->setSettings($settings);
+        $index->setSettings(Json::decode($jsonSettings));
 
         $this->info('All settings for ['.$class.'] index have been pushed.');
     }