refactor(vue): replace instantsearch.js with instantsearch-core (#6440)

* refactor(vue): replace instantsearch.js with instantsearch-core

[FX-3069]

BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication

* fix!

* fix for vue 2

* hup

* prevent double search

Author: Haroenv

examples/vue/default-theme/package.json

@@ -10,7 +10,7 @@
   "dependencies": {
     "algoliasearch": "5.1.1",
     "core-js": "2",
-    "instantsearch.js": "4.75.3",
+    "instantsearch-core": "0.1.0",
     "vue": "2.7.14",
     "vue-instantsearch": "4.19.9"
   },

examples/vue/default-theme/src/App.vue

@@ -124,8 +124,7 @@
 
 <script>
 import { liteClient as algoliasearch } from 'algoliasearch/lite';
-import { history as historyRouter } from 'instantsearch.js/es/lib/routers';
-import { simple as simpleMapping } from 'instantsearch.js/es/lib/stateMappings';
+import { historyRouter, simpleStateMapping } from 'instantsearch-core';
 
 import './App.css';
 
@@ -140,7 +139,7 @@ export default {
         router: historyRouter({
           cleanUrlOnDispose: false,
         }),
-        stateMapping: simpleMapping(),
+        stateMapping: simpleStateMapping(),
       },
     };
   },

examples/vue/e-commerce/package.json

@@ -10,7 +10,7 @@
   "dependencies": {
     "algoliasearch": "5.1.1",
     "core-js": "2",
-    "instantsearch.js": "4.75.3",
+    "instantsearch-core": "0.1.0",
     "vue": "2.7.14",
     "vue-instantsearch": "4.19.9",
     "vue-slider-component": "3.0.32"

examples/vue/e-commerce/src/routing.js

@@ -1,6 +1,6 @@
 /* eslint-disable camelcase */
 /* eslint-disable complexity */
-import { history as historyRouter } from 'instantsearch.js/es/lib/routers';
+import { historyRouter } from 'instantsearch-core';
 
 const hitsPerPageItemsValue = [16, 32, 64];
 

examples/vue/e-commerce/src/widgets/ClearRefinements.vue

@@ -11,7 +11,7 @@
 </template>
 
 <script>
-import { connectClearRefinements } from 'instantsearch.js/es/connectors';
+import { connectClearRefinements } from 'instantsearch-core';
 import { createWidgetMixin } from 'vue-instantsearch';
 
 export default {

examples/vue/e-commerce/src/widgets/NoResults.vue

@@ -115,7 +115,7 @@
 </template>
 
 <script>
-import { connectHits } from 'instantsearch.js/es/connectors';
+import { connectHits } from 'instantsearch-core';
 import { createWidgetMixin } from 'vue-instantsearch';
 
 export default {

examples/vue/getting-started/package.json

@@ -9,7 +9,7 @@
   "dependencies": {
     "algoliasearch": "5.1.1",
     "core-js": "2",
-    "instantsearch.js": "4.75.3",
+    "instantsearch-core": "0.1.0",
     "vue": "2.7.14",
     "vue-instantsearch": "4.19.9"
   },

examples/vue/media/package.json

@@ -10,7 +10,7 @@
   "dependencies": {
     "algoliasearch": "5.1.1",
     "core-js": "2",
-    "instantsearch.js": "4.75.3",
+    "instantsearch-core": "0.1.0",
     "vue": "2.7.14",
     "vue-instantsearch": "4.19.9"
   },

examples/vue/media/src/App.vue

@@ -113,8 +113,7 @@
 
 <script>
 import { liteClient as algoliasearch } from 'algoliasearch/lite';
-import { history as historyRouter } from 'instantsearch.js/es/lib/routers';
-import { simple as simpleMapping } from 'instantsearch.js/es/lib/stateMappings';
+import { historyRouter, simpleStateMapping } from 'instantsearch-core';
 
 import './App.css';
 
@@ -129,7 +128,7 @@ export default {
         router: historyRouter({
           cleanUrlOnDispose: false,
         }),
-        stateMapping: simpleMapping(),
+        stateMapping: simpleStateMapping(),
       },
     };
   },

packages/vue-instantsearch/__mocks__/instantsearch.js/es.js

@@ -37,7 +37,7 @@
   },
   "dependencies": {
     "instantsearch-ui-components": "0.9.0",
-    "instantsearch.js": "4.75.3",
+    "instantsearch-core": "0.1.0",
     "mitt": "^2.1.0"
   },
   "peerDependencies": {

packages/vue-instantsearch/package.json

@@ -14,7 +14,7 @@ import {
   connectRatingMenu,
   connectRefinementList,
   connectToggleRefinement,
-} from 'instantsearch.js/es/connectors';
+} from 'instantsearch-core';
 
 import { nextTick, mountApp } from '../../test/utils';
 import {
@@ -24,7 +24,6 @@ import {
   createWidgetMixin,
 } from '../instantsearch';
 import { renderCompat } from '../util/vue-compat';
-jest.unmock('instantsearch.js/es');
 
 const testSetups = {
   async createRefinementListConnectorTests({

packages/vue-instantsearch/src/__tests__/common-connectors.test.js

@@ -3,7 +3,7 @@
  */
 import { runTestSuites } from '@instantsearch/tests/common';
 import * as testSuites from '@instantsearch/tests/shared';
-import { connectMenu, connectPagination } from 'instantsearch.js/es/connectors';
+import { connectMenu, connectPagination } from 'instantsearch-core';
 
 import { nextTick, mountApp } from '../../test/utils';
 import {
@@ -14,7 +14,6 @@ import {
   createWidgetMixin,
 } from '../instantsearch';
 import { renderCompat } from '../util/vue-compat';
-jest.unmock('instantsearch.js/es');
 
 const testSetups = {
   async createSharedTests({ instantSearchOptions, widgetParams }) {

packages/vue-instantsearch/src/__tests__/common-shared.test.js

@@ -32,8 +32,6 @@ import {
 } from '../instantsearch';
 import { renderCompat } from '../util/vue-compat';
 
-jest.unmock('instantsearch.js/es');
-
 /**
  * prevent rethrowing InstantSearch errors, so tests can be asserted.
  * IRL this isn't needed, as the error doesn't stop execution.
@@ -327,8 +325,8 @@ const testSetups = {
 
     return {
       algoliaAgents: [
-        `instantsearch.js (${
-          require('../../../instantsearch.js/package.json').version
+        `instantsearch-core (${
+          require('../../../instantsearch-core/package.json').version
         })`,
         `Vue InstantSearch (${
           require('../../../vue-instantsearch/package.json').version

packages/vue-instantsearch/src/__tests__/common-widgets.test.js

@@ -3,6 +3,7 @@
  */
 
 /* eslint-disable jest/no-conditional-expect */
+import { createSearchClient } from '@instantsearch/mocks';
 
 import { mount } from '../../test/utils';
 import InstantSearch from '../instantsearch';
@@ -86,11 +87,7 @@ function getAllComponents() {
             {
               props: {
                 indexName: 'instant_search',
-                searchClient: {
-                  search() {
-                    return new Promise({ results: [] });
-                  },
-                },
+                searchClient: createSearchClient(),
               },
             },
             [

packages/vue-instantsearch/src/__tests__/index.js

@@ -20,7 +20,7 @@
 </template>
 
 <script>
-import { connectAutocomplete } from 'instantsearch.js/es/connectors';
+import { connectAutocomplete } from 'instantsearch-core';
 
 import { createSuitMixin } from '../mixins/suit';
 import { createWidgetMixin } from '../mixins/widget';

packages/vue-instantsearch/src/components/Autocomplete.vue

@@ -55,7 +55,7 @@
 </template>
 
 <script>
-import { connectBreadcrumb } from 'instantsearch.js/es/connectors';
+import { connectBreadcrumb } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';

packages/vue-instantsearch/src/components/Breadcrumb.vue

@@ -19,7 +19,7 @@
 </template>
 
 <script>
-import { connectClearRefinements } from 'instantsearch.js/es/connectors';
+import { connectClearRefinements } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';

packages/vue-instantsearch/src/components/ClearRefinements.vue

@@ -1,4 +1,4 @@
-import { connectConfigure } from 'instantsearch.js/es/connectors';
+import { connectConfigure } from 'instantsearch-core';
 
 import { createSuitMixin } from '../mixins/suit';
 import { createWidgetMixin } from '../mixins/widget';

packages/vue-instantsearch/src/components/Configure.js

@@ -51,7 +51,7 @@
 </template>
 
 <script>
-import { connectCurrentRefinements } from 'instantsearch.js/es/connectors';
+import { connectCurrentRefinements } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';

packages/vue-instantsearch/src/components/CurrentRefinements.vue

@@ -1,4 +1,4 @@
-import { connectDynamicWidgets } from 'instantsearch.js/es/connectors';
+import { connectDynamicWidgets } from 'instantsearch-core';
 
 import { createSuitMixin } from '../mixins/suit';
 import { createWidgetMixin } from '../mixins/widget';

packages/vue-instantsearch/src/components/DynamicWidgets.js

@@ -39,7 +39,7 @@
 </template>
 
 <script>
-import { connectHierarchicalMenu } from 'instantsearch.js/es/connectors';
+import { connectHierarchicalMenu } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';

packages/vue-instantsearch/src/components/HierarchicalMenu.vue

@@ -1,9 +1,9 @@
-import { createHighlightComponent } from 'instantsearch-ui-components';
 import {
   getHighlightedParts,
   getPropertyByPath,
   unescape,
-} from 'instantsearch.js/es/lib/utils';
+} from 'instantsearch-core';
+import { createHighlightComponent } from 'instantsearch-ui-components';
 
 import { createElement, Fragment } from '../util/pragma';
 

packages/vue-instantsearch/src/components/Highlighter.js

@@ -1,5 +1,5 @@
+import { connectHits } from 'instantsearch-core';
 import { createHitsComponent } from 'instantsearch-ui-components';
-import { connectHits } from 'instantsearch.js/es/connectors';
 
 import { createSuitMixin } from '../mixins/suit';
 import { createWidgetMixin } from '../mixins/widget';

packages/vue-instantsearch/src/components/Hits.js

@@ -26,7 +26,7 @@
 </template>
 
 <script>
-import { connectHitsPerPage } from 'instantsearch.js/es/connectors';
+import { connectHitsPerPage } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';

packages/vue-instantsearch/src/components/HitsPerPage.vue

@@ -1,4 +1,4 @@
-import indexWidget from 'instantsearch.js/es/widgets/index/index';
+import { index as indexWidget } from 'instantsearch-core';
 
 import { createSuitMixin } from '../mixins/suit';
 import { createWidgetMixin } from '../mixins/widget';

packages/vue-instantsearch/src/components/Index.js

@@ -100,7 +100,7 @@
 </template>
 
 <script>
-import { connectInfiniteHits } from 'instantsearch.js/es/connectors';
+import { connectInfiniteHits } from 'instantsearch-core';
 
 import { createSuitMixin } from '../mixins/suit';
 import { createWidgetMixin } from '../mixins/widget';

packages/vue-instantsearch/src/components/InfiniteHits.vue

@@ -1,4 +1,4 @@
-import instantsearch from 'instantsearch.js/es';
+import { instantsearch } from 'instantsearch-core';
 
 import { createInstantSearchComponent } from '../util/createInstantSearchComponent';
 import { renderCompat, getDefaultSlot } from '../util/vue-compat';

packages/vue-instantsearch/src/components/InstantSearch.js

@@ -48,7 +48,7 @@
 </template>
 
 <script>
-import { connectMenu } from 'instantsearch.js/es/connectors';
+import { connectMenu } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';

packages/vue-instantsearch/src/components/Menu.vue

@@ -34,7 +34,7 @@
 </template>
 
 <script>
-import { connectMenu } from 'instantsearch.js/es/connectors';
+import { connectMenu } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';

packages/vue-instantsearch/src/components/MenuSelect.vue

@@ -34,7 +34,7 @@
 </template>
 
 <script>
-import { connectNumericMenu } from 'instantsearch.js/es/connectors';
+import { connectNumericMenu } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';

packages/vue-instantsearch/src/components/NumericMenu.vue

@@ -165,7 +165,7 @@
 </template>
 
 <script>
-import { connectPagination } from 'instantsearch.js/es/connectors';
+import { connectPagination } from 'instantsearch-core';
 
 import { createPanelConsumerMixin } from '../mixins/panel';
 import { createSuitMixin } from '../mixins/suit';