chore: don't transform facets as disjunctive if they have no value selected (#6606)

* chore: don't transform facets as disjunctive if they have no value selected

* fix: properly test disjunctive facets with & without value

Author: e-krebs

packages/algoliasearch-helper/src/requestBuilder.js

@@ -187,7 +187,16 @@ var requestBuilder = {
     var facets = state.facets
       .concat(
         state.disjunctiveFacets.map(function (value) {
-          return 'disjunctive(' + value + ')';
+          if (
+            state.disjunctiveFacetsRefinements &&
+            state.disjunctiveFacetsRefinements[value] &&
+            state.disjunctiveFacetsRefinements[value].length > 0
+          ) {
+            // only tag a disjunctiveFacet as disjunctive if it has a value selected
+            // this helps avoid hitting the limit of 20 disjunctive facets in the Composition API
+            return 'disjunctive(' + value + ')';
+          }
+          return value;
         })
       )
       .concat(requestBuilder._getHitsHierarchicalFacetsAttributes(state))

packages/instantsearch.js/src/lib/__tests__/InstantSearch-composition-test.tsx

@@ -178,7 +178,8 @@ describe('Composition implementation', () => {
       search.addWidgets([
         configure({
           facets: ['brand'],
-          disjunctiveFacets: ['categories'],
+          disjunctiveFacets: ['categories', 'author'],
+          disjunctiveFacetsRefinements: { author: ['Terry Pratchett'] },
         }),
         virtualSearchBox({}),
       ]);
@@ -190,7 +191,11 @@ describe('Composition implementation', () => {
       expect(searchClient.search).toHaveBeenNthCalledWith(1, {
         compositionID: 'my-composition',
         requestBody: {
-          params: { query: '', facets: ['brand', 'disjunctive(categories)'] },
+          params: {
+            query: '',
+            facets: ['brand', 'categories', 'disjunctive(author)'],
+            facetFilters: [['author:Terry Pratchett']],
+          },
         },
       });
     });